-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swagger #feature #1094
Comments
👍 It should be configurable though; whether it should be accessible, at which route, by whom etc.. |
👍 actually a must have |
👍 Swagger has an express module that might be useful to build on. |
👍 An API is only as good as the documentation you provide :-) |
👍 |
3 similar comments
👍 |
👍 |
👍 |
at first glance, it looks like a swagger adapter would be easy to write, where the model schemas would be marshalled to JSON schema. If the adapter can get a handle to the controllers and routes, the rest should be easy. |
👍 |
but yeah srsly guys I think this would be pretty sweet. |
I'm actually working on this already. Not using swagger, but similar idea. That's why I ran into the issue of there being duplicate routes. If anyone feels like helping out or sharing thoughts, drop me a message. |
@RWOverdijk awesome! |
@RWOverdijk how about collaborating and getting this working with swagger? |
Isn't it non-core to "invent your own" whe swagger is a maintained system that could be an optional dependency instead?...just saying— On Thu, Mar 6, 2014 at 9:46 PM, Tony Tam [email protected] wrote:
|
Developers are always "inventing their own" if they think that the alternatives aren't good enough. |
sure thing. being the swagger spec maintainer, i'm happy to help implement this with some collaboration with the sails community. |
@fehguy We could still pull this off. I already have a list of routes, I just have to discuss which should go in, and how to gather descriptions. You could then use the data for swagger, and I can use it for Barque/Kamal. |
@fehguy appreciate that :) Swagger looks fantastic- look forward to chatting about it soon. We mentioned a weekly hangout a while ago, and this might be a good first topic. I'll post to the google group with some suggested times later this afternoon. |
Is it there yet? Or yet to be added? If it haven't implemented yet. Any guide line how to implement it? |
Oh man! I'm so stoked to have this!!! 👍 |
guys, we're aware of this and we really want to see it happen. Check out the new |
@mikermcneil thanks for reply. Where I can found details for |
@kunjee17 did you find the information for |
This email account is inactive http://www.wavebreakmedia.com/stock-photo-video-footage-i-74/Contact-Us.html |
@eddieajau not as of now... :( |
When is swagger integration planned to be released? I can help if needed. |
+1 |
+1 |
+1 |
I don't fully understand the last comment from @mikermcneil about the |
+2 |
+1 |
We have a lot of interest to do this. I'm happy to help contribute if someone wants to join me with some pointers on getting to the routes, etc inside of sails. |
I've set up a repo based on sails's express instance is |
Just FYI, swagger-express only works with Swagger 1.2... |
Ah ok, looks like forking https://github.com/paulhill/swagger-n will be a better way to start then. |
This is the direction swagger for node has been going: https://github.com/swagger-api/swagger-codegen/tree/master/samples/server/petstore/nodejs This uses the swagger specification (JSON format in this example) as the DSL that routes http requests to a controller. It's relying on middleware from the apigee-127 project by @whitlockjc. I believe that with this--and the hooks into sails routing may be a killer combo. I'll dig into the sails router shortly. BTW the swagger-tools project works with both 1.2 and 2.0 specs, and is thoroughly tested. |
+1 |
At this point we're looking for a team of community members to help out. It looks like there's a ton of interest here, we're just swamped at the moment at Balderdash. I think @renanvieira wants to help out too. Do you guys want to fork https://github.com/tjwebb/sails-swagger and get started there? A basic API generator would be an awesome first step :) I can help out here and there where I can, and review PRs Here are some examples: https://github.com/swagger-api/swagger-spec#nodejs Feel free to file issues, requests, ideas, and comments in that repository. Thanks! |
I am going to take a look at it, I see swagger as a documentation tool more than an API generator, and that's where my focus will go. |
Hi ! |
Yet another +1 |
+1 |
👍 love to see swagger in Sails. |
I've just released sway, the API behind swagger-tools, and the plan is to create some sway-based middleware/plugins/integrations for Connect, Express, Hapi, Restify and Sails. I'll update this issue as things progress. |
Hey guys, I built a swagger sails hook that generates a Swagger 2.0 document: https://github.com/tjwebb/sails-swagger It's alpha-quality at this point, but it basically works. |
This is awesome, thank you! |
@tjwebb thank you! |
@tjwebb Thanks for your work ! There is any hope to see it working soon? |
It currently only works on master, I hope to see the latest sails released On Tue, Sep 29, 2015 at 4:50 AM, orhemi [email protected] wrote:
|
Looking forward to trying out swagger-sails when sails.js 0.12 is released |
anyone here can check out this library i think it better solve the problem and open for contributions https://github.com/theo4u/sails-hook-swagger-generator |
Add Swagger to AUTO document the API in any project:
https://developers.helloreverb.com/swagger/
It would go well with the overall Sails mentality.
sample in use here:
http://swagger.wordnik.com/#!/pet
The text was updated successfully, but these errors were encountered: