unit tests for PoolConfigLib

[elshan-eth]

Description

Added unit tests for Pool ConfigLib but the coverage result is wrong -_-

Type of change

• Bug fix
• New feature
• Breaking change
• Dependency changes
• Code refactor / cleanup
• Documentation or wording changes
• Other

Checklist:

• The diff is legible and has no extraneous changes
• Complex code has been commented, including external interfaces
• Tests have 100% code coverage
• The base branch is either main, or there's a description of how to merge

Issue Resolution

Closes #497, #498

[joaobrunoah]

Nice tests! Much clearer than checking bytes only

[joaobrunoah]

Nice!

[elshan-eth]

Thanks!

[EndymionJkb]

Very thorough :) Some of this might be redundant/overkill, as we have very robust tests for WordCodec, which underpins all of this.

However, it is testing that the constant offsets don't step on each other (which could be missed by other tests), and that the bits "line up" with the corresponding functions.

We don't modify this too often, so I suppose it isn't too onerous to maintain. Odd that it updates snaps when all we're doing is tests. I guess they were out-of-date? Make sure it's updated from latest main and rerun to see if those go away.

The only substantive thing is the "crete" function naming; other than that, I'll never complain about adding tests :)

[elshan-eth]

Very thorough :) Some of this might be redundant/overkill, as we have very robust tests for WordCodec, which underpins all of this.

However, it is testing that the constant offsets don't step on each other (which could be missed by other tests), and that the bits "line up" with the corresponding functions.

We don't modify this too often, so I suppose it isn't too onerous to maintain. Odd that it updates snaps when all we're doing is tests. I guess they were out-of-date? Make sure it's updated from latest main and rerun to see if those go away.

The only substantive thing is the "crete" function naming; other than that, I'll never complain about adding tests :)

I wanted to check every function, offset, and that the data in the structure exactly matches the bits. Maybe it's too much😅