Avalanche root gauge factory v2 #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EndymionJkb
reviewed
Aug 4, 2023
EndymionJkb
reviewed
Aug 4, 2023
pkg/liquidity-mining/contracts/gauges/avalanche/AvalancheRootGauge.sol
Outdated
Show resolved
Hide resolved
EndymionJkb
reviewed
Aug 4, 2023
jubeira
commented
Aug 9, 2023
Comment on lines
+227
to
+232
| if (_lzBALProxy.useCustomAdapterParams()) { | ||
| uint256 minDstGas = _lzBALProxy.minDstGasLookup(_AVALANCHE_LZ_CHAIN_ID, _SEND_PACKET_TYPE); | ||
| return abi.encodePacked(_ADAPTER_PARAMS_VERSION, minDstGas); | ||
| } else { | ||
| return bytes(""); | ||
| } |
There was a problem hiding this comment.
It wasn't trivial to get this right, but this should:
- not revert downstream after the bal proxy takes over the execution
- not require any additional config. Also, by performing the same operations that the proxy will perform when it's called, we should hit the same storage slots and perform warm reads which are cheaper.
The only way to actually test this properly is in the fork test. I've added some tests at the end that bridge BAL tokens many times using different amounts for both configurations in balancer/balancer-deployments#76.
EndymionJkb
approved these changes
Aug 9, 2023
pkg/liquidity-mining/contracts/gauges/avalanche/AvalancheRootGauge.sol
Outdated
Show resolved
Hide resolved
pkg/liquidity-mining/contracts/gauges/avalanche/AvalancheRootGauge.sol
Outdated
Show resolved
Hide resolved
pkg/liquidity-mining/contracts/gauges/avalanche/AvalancheRootGaugeLib.sol
Show resolved
Hide resolved
| return amount - dust; | ||
| } | ||
|
|
||
| function bytes32Recipient(address recipient) internal pure returns (bytes32) { |
There was a problem hiding this comment.
Could also comment here why we need to cast it: some networks have different address sizes?
There was a problem hiding this comment.
Added a short description.
This is what the proxy accepts anyway, as it can be seen in the gauge code. It's just separated so that it can be tested easily (testing with the factory and the proxy outside a fork test is a nightmare).
Co-authored-by: EndymionJkb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces new root gauge that can bridge tokens using the new LZ contract as described in #2531.
Type of change
Checklist:
master, or there's a description of how to mergeIssue Resolution
Closes #2531.