Reentrancy Preparation: Managed Pool #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
reviewed
Feb 27, 2023
jubeira
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Changes look good.
I've been through the document and I agree that these are the affected functions to document and protect, and that this PR properly implements the fix.
I only have one comment regarding the wording of the protected functions, considering that with this patch they are actually safe to call.
…ived contracts could still be written to be vulnerable)
9 tasks
jubeira
pushed a commit
to jubeira/balancer-v2-monorepo
that referenced
this pull request
Jun 13, 2023
commit 9c1574b7d8c4f5040a016cdf79b9d2cc47364fd9 Author: Juan Ignacio Ubeira <[email protected]> Date: Thu Jun 8 18:12:12 2023 -0300 `v2-pool-utils` NPM release: v4.1.0/1. (#2513) commit d9e6c7779b75d4e554549d9bb896e7f9630af164 Author: Juan Ignacio Ubeira <[email protected]> Date: Thu Jun 8 12:36:25 2023 -0300 Improve expect event (#2519) commit 2b2192e5f407dd9d7e72ce0e9dbcfa2613fd65f5 Author: Juan Ignacio Ubeira <[email protected]> Date: Thu Jun 8 12:02:37 2023 -0300 Fix `BalancerErrors` compiler range (#2520) commit 5bb22b2ffeed69bc296b6d2b23c9b61ce0833e26 Author: Juan Ignacio Ubeira <[email protected]> Date: Thu Jun 8 11:55:04 2023 -0300 Remove deployments package. (#2504) commit d2c47f13aa5f7db1b16e37f37c9631b9a38f25a4 Author: Juan Ignacio Ubeira <[email protected]> Date: Wed Jun 7 16:24:35 2023 -0300 Relayer: Chain internal balance operations (outstanding comments) (#2517) commit 58ba10b3fa6ed03cf9493f71336e2ab00530e51b Author: EndymionJkb <[email protected]> Date: Wed Jun 7 15:23:57 2023 -0400 docs: doc links changed (#2518) commit d96307b268f84531292cdb094d368c994a0616d5 Author: EndymionJkb <[email protected]> Date: Wed Jun 7 12:53:40 2023 -0400 Relayer: Chain internal balance operations (#2515) * feat: allow chaining internal balance operations * test: add emergency exit * refactor: simplify reference structure for user balances (no lookup required) * docs: cleanup commit 7b2ab0a158b363acd8be8d3b01117d13d4e3d05d Author: Igor Yalovoy <[email protected]> Date: Mon Jun 5 14:56:28 2023 -0600 Avoid wasting gas on vault reentrancy check (#2467) commit db24e8372ac7fa51e5db65bfa961697382f68337 Author: EndymionJkb <[email protected]> Date: Fri Jun 2 17:25:19 2023 -0500 Avalanche Root Gauge (#2507) * checkpoint * Add unit test for bridge range tests that are too difficult to test in a fork * docs: add comments; simplify mocks * lint * refactor: rename factory to bridgeLimitsProvider; improve docs * refactor: enforce bridge limit sanity checks * fix: parameter check commit 2023f8d01c9c17b33ba44827d461b743489e3fde Author: Juan Ignacio Ubeira <[email protected]> Date: Fri Jun 2 18:03:28 2023 -0300 Fix types in TS test for `CompoundWrapping`. (#2511) commit 6cb145e6b71ef92c35a642f1060d4a0d22e80a2c Author: Juan Ignacio Ubeira <[email protected]> Date: Tue May 30 12:33:46 2023 -0300 Make `peekChainedReferenceValue` payable, non-view. (#2509) commit cbce7d63479dafb4f4ea9ad8cb2dbdbb26edae50 Author: Juan Ignacio Ubeira <[email protected]> Date: Tue May 23 21:48:25 2023 -0300 Deployments deprecation notice. (#2506) commit 0e517b69d03a304efdf3ac511beaa6ee2e55adfc Author: Juan Ignacio Ubeira <[email protected]> Date: Tue May 23 12:26:18 2023 -0300 Adjust gauge adder coordinator with current authorizer wrapper compatibility. (#2505) Co-authored-by: Juan Ignacio Ubeira <[email protected]> commit fe78fcdda905cc775ef6b44558d38ab2a0e303e5 Author: Juan Ignacio Ubeira <[email protected]> Date: Mon May 22 13:27:40 2023 -0300 Checkpointer: single gauge checkpoint (#2479) * Make gauge types dynamic in `GaugeAdder`. * Remove support for multiple factories for gauge type. * Update adder migration coordinator. * Improve tests, polish code. * Lint governance scripts. * Fix checkpointer test. * Update changelog. * Add gnosis root gauge factory to adder migration coordinator. * Remove gauge type number. * Remove internal bytes32 representation for gauge types. * Refactor common require. * Fix governance scripts. * Adapt checkpointer test. * Apply suggestions from code review Co-authored-by: Nicolás Venturo <[email protected]> * Address comments and adjust tests. * Fix gauge types for L2 gauge checkpointer. - Not dynamic, but OK for the foreseeable future. * Fix gauge types in fork test. * Adjust interface. * Remove `override`. * Update changelog. * Fix test. * Add single checkpoint capability in `L2GaugeCheckpointer`. * Update changelog. * Fix gauge type. --------- Co-authored-by: Juan Ignacio Ubeira <[email protected]> Co-authored-by: Nicolás Venturo <[email protected]> commit 1a65dd45a4315e96b445cac0e646b73e5d0941bc Author: Juan Ignacio Ubeira <[email protected]> Date: Fri May 19 18:45:44 2023 -0300 Adapt `L2GaugeCheckpointer` to new networks (#2500) commit ee1b3bbacd4c8671422a59b5edc04829b7a7762c Author: Juan Ignacio Ubeira <[email protected]> Date: Fri May 19 17:24:31 2023 -0300 Add Polygon ZK EVM to gauge adder migrator (V3 --> V4) (#2502) commit dabce3b02e6d97c0b16cfbd6a453cc9a331e0096 Author: Juan Ignacio Ubeira <[email protected]> Date: Thu May 18 16:43:29 2023 -0300 Make gauge types dynamic in `GaugeAdder`. (#2494) commit cece9047f783ed0ee92ad847853badfa8018898c Author: Nicolás Venturo <[email protected]> Date: Thu May 18 15:14:54 2023 -0300 Make Timelock grant and revoke consistent (#2499) * Make grantPermission consistent * Make revokePermission consistent * Make removeCanceler consistent * Make revoke consistent * Add some more tests * Clarify addGranter and grantPerm commit e1ac0108b24d568de133d465d79fc7fb9feea499 Author: EndymionJkb <[email protected]> Date: Thu May 18 12:26:52 2023 -0400 chore: update audit to reflect latest report (links to canceler changes) (#2501) commit 538687652ec6e49c4f4276a39cf3ac47b2964dce Author: Nicolás Venturo <[email protected]> Date: Wed May 17 15:49:01 2023 -0300 Prepare zkEVM deployment (#2474) * Prepare for ZKEVM * Begin ZKEVM deployment * non-pool deployments * LBP factory deployment * finish LBP + batch relayer * Managed Pool libraries * Managed Pool library addresses * Update pkg/deployments/package.json * Deploy remaining pools * docs: catchup on output links * deploy last straggler! * fix: add RPC_ENDPOINT to ci.yml * Update .github/workflows/ci.yml * Add empty accounts * Update prepare-config.ts --------- Co-authored-by: Jeffrey Bennett <[email protected]> commit 3e2c923eee03957818931625e9bb8ba129b64836 Author: Nicolás Venturo <[email protected]> Date: Wed May 17 13:58:00 2023 -0300 Remove Timelock permission ids (#2497) * Remove permission id functions * Remove permission ids fully * Clarify docs commit 6a13c45446d2b216fcf2748d231ab4e2f53c5a3d Author: Nicolás Venturo <[email protected]> Date: Wed May 17 13:28:15 2023 -0300 Timelock spelling and naming improvements (#2495) * Move comments around * s/canceller/canceler * Rename sched action to sched exec * Rename revert reasons * Apply suggestions from code review Co-authored-by: EndymionJkb <[email protected]> * Fix linter --------- Co-authored-by: EndymionJkb <[email protected]> commit 3a15245c5a9cefd51220f1beeefb4ec487e8bd5d Author: EndymionJkb <[email protected]> Date: Wed May 17 12:22:25 2023 -0400 Polygon ZkEVM Root Gauge (#2492) * feat: zkevm root gauge, using canonical bridge * fix: 0x != empty commit 785451f18055e91d5a13d527efb80ddc300fa5b9 Author: Nicolás Venturo <[email protected]> Date: Mon May 15 15:21:24 2023 -0300 Remove misleading comment (#2486) commit 77f2390e9ea7b7f92482f9692e92cd45709ee055 Author: Nicolás Venturo <[email protected]> Date: Mon May 15 15:20:57 2023 -0300 Make the root transfer delay configurable (#2487) commit de10864659369d311fd2d8a481b78ea30d41228c Author: Nicolás Venturo <[email protected]> Date: Mon May 15 15:18:54 2023 -0300 Forbid adding cancelers for non-existent or non-pending scheduled executions (#2489) commit 3eb1a457697be70e2c42add048276490c2cdd185 Author: Nicolás Venturo <[email protected]> Date: Mon May 15 12:56:45 2023 -0300 Timelock authorizer scheduled tasks auditability (#2485) * Simple extension to allow for auditability of scheduled tasks onchain - Extend the ScheduledExecution struct with fields for better auditability - Add getNumScheduledExecutions to return the length of the array - Add getScheduledExecutions to allow for fetching part of the array * fix for loop idxs * Update pkg/vault/contracts/authorizer/TimelockAuthorizerManagement.sol Co-authored-by: Nicolás Venturo <[email protected]> * Update pkg/vault/contracts/authorizer/TimelockAuthorizerManagement.sol Co-authored-by: Nicolás Venturo <[email protected]> * Update pkg/vault/contracts/authorizer/TimelockAuthorizerManagement.sol Co-authored-by: Igor Yalovoy <[email protected]> * disable no-rely-on-time for the entire file * Add functions to interface, and function docs * Fix imports and overrides * Add basic schedule/cancel/execute info tests * Add more schedule info tests * Rename args and improve docs * Add getScheduledExecutions tests * Improve maxsize tests * Apply suggestions from code review Co-authored-by: Juan Ignacio Ubeira <[email protected]> --------- Co-authored-by: Daniel <[email protected]> Co-authored-by: Daniel <[email protected]> Co-authored-by: Igor Yalovoy <[email protected]> Co-authored-by: Juan Ignacio Ubeira <[email protected]> commit 3c80f17dc8d446320ed2b24856035da120a00adc Author: Nicolás Venturo <[email protected]> Date: Sun May 14 19:58:29 2023 -0300 Add Certora TimelockAuthorizer audit (#2488) commit 21e028ca8fe31beff6c90e007739b85ce8d8c4c6 Author: Nicolás Venturo <[email protected]> Date: Fri May 12 12:18:50 2023 -0300 Add fork test with gauge liq limit update (#2403) * Add fork test with gauge liq limit update * Make tests independent * Update pkg/deployments/tasks/20230314-batch-relayer-v5/test/test.fork.ts Co-authored-by: Juan Ignacio Ubeira <[email protected]> --------- Co-authored-by: Juan Ignacio Ubeira <[email protected]> Co-authored-by: Juan Ignacio Ubeira <[email protected]> commit 9273dc0a82a27f48f590ddc1fe03470458bfc9b2 Author: Juan Ignacio Ubeira <[email protected]> Date: Thu May 11 11:27:49 2023 -0300 Update deployment addresses (#2476) commit 5d3b259cd09fbd9c5ac08392f39a6534f6824832 Author: Juan Ignacio Ubeira <[email protected]> Date: Thu May 11 10:42:42 2023 -0300 Consider directories only for task IDs (#2484) commit 4a8b1b4a95e3704981dcf08abf401b735eca18de Author: EndymionJkb <[email protected]> Date: Tue May 9 13:29:33 2023 -0400 fix: remove duplicate addresses from deployment-txs (#2480) commit b6804a4d75283887195e2bb0e03e35666d8612ec Author: EndymionJkb <[email protected]> Date: Tue May 9 13:03:41 2023 -0400 Deploy pool on LBP factory deployment (#2477) * feat: deploy LBP from factory (like weighted and stable), to allow generating action ids * docs: remove debug code commit 2dc354f106db6d166c96ecb7f5c6d436e2636afe Author: Nicolás Venturo <[email protected]> Date: Mon May 8 14:38:55 2023 -0300 Sepolia deployment (#2471) * Prepare sepolia * Do Vault deployment * update hardhat-etherscan * feat: add initial deployments (rest pending admin account, BAL, etc.) * feat: finish deployments * refactor: fix LBP action id name; add addresses * revert unintended config change * stragglers --------- Co-authored-by: Jeffrey Bennett <[email protected]> commit 53e26c6c9b059bc1529c705448f69ee7c729ff6e Author: Juan Ignacio Ubeira <[email protected]> Date: Mon May 8 13:46:53 2023 -0300 Update changelog. (#2478) Co-authored-by: Juan Ignacio Ubeira <[email protected]> commit e93b23516af8364303ab550d4b662b09d7fddfc5 Author: Juan Ignacio Ubeira <[email protected]> Date: Mon May 8 09:50:37 2023 -0300 Deployment preparation: `VotingEscrowRemapper` (with adaptor) (#2470) commit 6718c40c6d1a169c212a93a68bdebb7444a5cc6f Author: Juan Ignacio Ubeira <[email protected]> Date: Fri May 5 16:32:38 2023 -0300 Add `OmniVotingEscrowAdaptor` (#2463) commit c0581671c040e1301fcd5f4d1450190aed5f2319 Author: EndymionJkb <[email protected]> Date: Wed May 3 13:42:57 2023 -0400 docs: add missing output links (#2457) commit 5cc087cc880b5b99dd78857624e331a0dcf313c1 Author: EndymionJkb <[email protected]> Date: Wed May 3 11:07:11 2023 -0400 Deployment: ChildChainGaugeFactory V2 (Avalanche catch-up) (#2453) * feat: catchup Avalanche deployment of ChildChainGaugeFactory (and supporting infrastructure) * cleanup: remove null action-ids commit 845aff0ae1a6d07dcecb0d033246cb5263da9ca7 Author: EndymionJkb <[email protected]> Date: Tue May 2 19:17:12 2023 -0400 Add deprecated silo deployment-txs (#2466) * fix: add deprecated silo deployment-txs * fix: same for goerli commit 8d4ea15173d7ef9e58a0490fd10162982c4cff80 Author: João Bruno Abou Hatem de Liz <[email protected]> Date: Tue May 2 18:59:05 2023 -0300 [2/2] Deployment: Silo Linear Pool Factory V2 (#2462) * Deploying to Mainnet and Goerli * Silo v2 deployments (missing linear pool) * Deployment of Silo Linear Pool * Silo action ids * Silo action ids for Goerli * Updating changelog * Fixing readme of Silo deployment * Removing commented code from Silo deployment script * Update pkg/deployments/deployment-txs/mainnet.json * Update pkg/deployments/package.json * Update pkg/deployments/package.json --------- Co-authored-by: EndymionJkb <[email protected]> commit 6b1342aff0dc28ae9b52ca5ba94c46279a9b1305 Author: Juan Ignacio Ubeira <[email protected]> Date: Tue May 2 18:35:36 2023 -0300 Update dependencies in GH actions. (#2464) commit ea90deadefa1cb303c28f8afc2f5891ea82f41e9 Author: João Bruno Abou Hatem de Liz <[email protected]> Date: Tue May 2 18:29:39 2023 -0300 Deployment of ERC4626LinearPoolFactory V4 to Avalanche (#2465) * Deployment of ERC4626 to Avalanche * Update pkg/deployments/deployment-txs/avalanche.json --------- Co-authored-by: EndymionJkb <[email protected]> commit 2a698757fbb6991c80f6bcce366ddc0d54d0afa9 Author: EndymionJkb <[email protected]> Date: Tue May 2 17:23:47 2023 -0400 Make VaultReentrancy check a view function (#2418) * refactor: make VaultReentrancy check a view function * docs: restore original comment * Put 100k limit on the static call * Comment * Limit gas for the staticcall * Update gas limit * Comment * docs: just rearrange comments a bit * test: add test for reentrancy protection on a view function * docs: clarify test names --------- Co-authored-by: Igor Yalovoy <[email protected]> commit 73d0ed205c8b4a16e050dbe592fa3c1446ee883a Author: João Bruno Abou Hatem de Liz <[email protected]> Date: Tue May 2 18:17:28 2023 -0300 [2/2] Deployment: Gearbox Linear Pool Factory V2 (#2461) * Deploy to Mainnet * Updating CHANGELOG * Update pkg/deployments/action-ids/mainnet/action-ids.json Co-authored-by: EndymionJkb <[email protected]> * Fixing Gearbox readme * Update pkg/deployments/action-ids/mainnet/action-ids.json --------- Co-authored-by: EndymionJkb <[email protected]> commit f7231d7002b7bc51f49b175e9c9754d378029ef7 Author: João Bruno Abou Hatem de Liz <[email protected]> Date: Tue May 2 17:45:59 2023 -0300 [2/2] Deployment: Aave Linear Pool Factory V5 (#2460) * Deploy to Optimism * Deploy to Arbitrum * Arbitrum and Optimism action-ids * Deploy to Polygon * Deploy to BSC * Deploy to Gnosis * Deploy to Mainnet * Update mainnet.json * Fixing Changelog * Update pkg/deployments/CHANGELOG.md Co-authored-by: EndymionJkb <[email protected]> * Update pkg/deployments/action-ids/bsc/action-ids.json Co-authored-by: EndymionJkb <[email protected]> * Update pkg/deployments/action-ids/gnosis/action-ids.json Co-authored-by: EndymionJkb <[email protected]> * Update pkg/deployments/action-ids/mainnet/action-ids.json Co-authored-by: EndymionJkb <[email protected]> * Update pkg/deployments/action-ids/polygon/action-ids.json Co-authored-by: EndymionJkb <[email protected]> * Fixing readme * Fixing readme * Deploying Aave to Avalanche --------- Co-authored-by: EndymionJkb <[email protected]> commit 4c1dfe2921eda6ee7510b526eac256f3304253be Author: EndymionJkb <[email protected]> Date: Tue May 2 16:07:39 2023 -0400 Vault dependency issues (#2455) * fix: dependency issues * fix: TestWETH location commit b74ca50e93dcbdcddd5385b180f2112c0cf8d99d Author: EndymionJkb <[email protected]> Date: Tue May 2 14:19:09 2023 -0400 fix: factoryOutput was in the wrong place (#2459) commit bcc59770c0169583492bc25540576711885a12cb Author: João Bruno Abou Hatem de Liz <[email protected]> Date: Tue May 2 13:49:40 2023 -0300 [2/2] Deployment: Yearn Linear Pool Factory V2 (#2442) * Deploy to optimism * Deploy to Arbitrum * Arbitrum and Optimism action-ids * Deploy to Polygon * Fixing polygon output * Deploy to Mainnet * Updating CHANGELOG * Update pkg/deployments/action-ids/mainnet/action-ids.json Co-authored-by: EndymionJkb <[email protected]> * Update pkg/deployments/action-ids/polygon/action-ids.json Co-authored-by: EndymionJkb <[email protected]> --------- Co-authored-by: EndymionJkb <[email protected]> commit 3ce5138abd8e336f9caf4d651184186fffcd2025 Author: Juan Ignacio Ubeira <[email protected]> Date: Fri Apr 28 16:21:02 2023 -0300 Use `uint16` for chainId in `VotingEscrowRemapper`. (#2454) commit b379c0c61b0f709ebbc83e806a1518436c05e184 Author: Nicolás Venturo <[email protected]> Date: Fri Apr 28 15:32:10 2023 -0300 Add VotingEscrowRemapper interface (#2425) commit 98e3d8c9be5a175f599c4e95d3ed3757bbc4e307 Author: Igor Yalovoy <[email protected]> Date: Fri Apr 28 07:59:55 2023 -0600 Add ChildChainGaugeRegistry (#2431) * Add ChildChainGaugeRegistry * Add removeGauge * Add ChildChainGaugeCheckpointer * Add import * Add tests * Lint * Address PR comments * Update pkg/liquidity-mining/contracts/gauges/ChildChainGaugeRegistry.sol Co-authored-by: Juan Ignacio Ubeira <[email protected]> * Update pkg/liquidity-mining/contracts/gauges/ChildChainGaugeRegistry.sol Co-authored-by: Juan Ignacio Ubeira <[email protected]> * Update pvt/helpers/src/test/expectEvent.ts Co-authored-by: Juan Ignacio Ubeira <[email protected]> * Fix tests * Lint --------- Co-authored-by: Juan Ignacio Ubeira <[email protected]> commit 8a6dbbd83d96ef036b44fe873fdb9abae184305d Author: EndymionJkb <[email protected]> Date: Thu Apr 27 14:29:29 2023 -0400 Refactor WeightedPool test helpers (#2099) * refactor: remove the deployer that is one big special case * refactor: generalize BasePool and introduce BaseWeighted for shared weighted functions * refactor: introduce classes for individual weighted pool types * test: update pool-utils tests using weighted pools * test: adjust weighted pool tests to use individual models * test: adjust dependencies in standalone utils * remove unused functions; move statics together * factor out pause parameter defaults * factor: adjust factory parameters * refactor: use string enum ManagedPoolType instead of string * lint: single vs double quotes * refactor: consistent capitalization * fix: consistent capitalization * checkpoint * lint * fix: overload TokenList.indicesOf * lint * docs: cleanup/clarify comments * allow WeightedPool to be created with all flavors of Account * create WeightedPool with signer owner commit 72f869c0faea8360b9e60d1eef3c69a50ea4669e Author: EndymionJkb <[email protected]> Date: Wed Apr 26 20:43:13 2023 -0400 Gauge Working Balance Helper (#2405) * checkpoint: L1 without BoostV2 * refactor: finish contract and update tests * refactor: simplify tests * refactor: use balance/supply ratios * refactor: rename mainnet variable to generalize * refactor: rename function, and add new tests * refactor: add functions for both raw balances and balance to supply ratios * refactor: adjust tests * refactor: remove optimization in favor of clarity * test: add ratio test * fix: delta could be negative; subtract after addition * feat: add veBAL decay test * Return votingEscrow as IERC20; docs update * refactor: clarify boolean param, add tests, randomize lock period * refactor: return an interface for the veDelegationProxy * fix: copy/past comment commit ea8e139d3825272802850957886da552dd01b736 Author: EndymionJkb <[email protected]> Date: Wed Apr 26 16:20:34 2023 -0400 Deployment: Composable Stable Pool V4 to Avalanche (#2450) * Add Avalanche deployment for stable pool * reorder readme so testnet is at the end commit d1b5382cbfd07fc92883252eace61ffb3c03f273 Author: EndymionJkb <[email protected]> Date: Wed Apr 26 13:54:32 2023 -0400 Deploy to Avalanche (became possible after network upgrade) (#2449) commit ec8d6952fc786db141d55883959d60e2c6437143 Author: Juan Ignacio Ubeira <[email protected]> Date: Tue Apr 25 17:35:35 2023 -0300 Upgrade node to v18.x (#2020) commit 9758427dba40004117ca38e850684542b42a49b0 Author: EndymionJkb <[email protected]> Date: Tue Apr 25 16:05:52 2023 -0400 Remove dead controller code (#2447) * refactor: remove dead code * lint commit 1e10a02b989e9959d172e3cda95d082afb134ffe Author: Juan Ignacio Ubeira <[email protected]> Date: Tue Apr 25 16:51:01 2023 -0300 Forge update - master. (#2448) commit 62e4b8ee7850ed242f527ae5ff6df2478d308b28 Author: EndymionJkb <[email protected]> Date: Mon Apr 24 18:41:35 2023 -0400 remove unused workspace (#2444) commit f36b1c35145ed9f1a718fb8f2777fd93b5536de1 Author: EndymionJkb <[email protected]> Date: Mon Apr 24 16:43:24 2023 -0400 fix: factoryOutput missing for mainnet/polygon ERC4626LinearPool (#2443) commit 5d42de72977ad2bfc3a9d58e6f291ba02d047be1 Author: João Bruno Abou Hatem de Liz <[email protected]> Date: Thu Apr 20 06:43:34 2023 -0300 [2/2] Deployment: ERC4626 Linear Pool Factory V4 (#2440) * Deploy to optimism * Deploy to Arbitrum * Arbitrum and Optimism action-ids * Deploy to Polygon * Deploy to Mainnet * Updating CHANGELOG commit 8f5458b63dd2245adbfae35acd4dc362daff16e9 Author: EndymionJkb <[email protected]> Date: Sat Apr 15 02:38:10 2023 -0400 Deployment: Authorizer with Adaptor Validation (#2438) * deploy to all networks * update changelog * update readme commit 60948308d9d57583a533821c6522506f5c653c5c Author: EndymionJkb <[email protected]> Date: Sat Apr 15 00:35:02 2023 -0400 Deployment preparation: Authorizer with Adaptor Validation (#2437) * initial commit * rename * add build-info * feat: add fork test * test: add gauge adder test * test: rename test to be more descriptive * Upgrade tests --------- Co-authored-by: Nicolás Venturo <[email protected]> commit 48792ab5d43b73de1546abbdf9e9e0e11a22a8a9 Author: EndymionJkb <[email protected]> Date: Fri Apr 14 16:40:31 2023 -0400 Authorizer with Adaptor Validation helper (#2417) * feat: add temporary authorizer with adaptor validation * Rename oldAuthorizer * Fix test signers * wip * test: expand tests * Improve tests * Add docs * Add top level docs * Update pkg/vault/test/authorizer/AuthorizerWithAdaptorValidation.test.ts Co-authored-by: EndymionJkb <[email protected]> * Update pkg/vault/contracts/authorizer/AuthorizerWithAdaptorValidation.sol Co-authored-by: EndymionJkb <[email protected]> --------- Co-authored-by: Nicolás Venturo <[email protected]> commit 597656439f1a10c56c921d0a9706f8aa0ef85205 Author: EndymionJkb <[email protected]> Date: Fri Apr 14 16:29:01 2023 -0400 Ascii art fix (#2436) * fix: spacing * fix: found another one commit 46174ee04deeeb911fba63180ac2852fb9864cd8 Author: Markus Buhatem Koch <[email protected]> Date: Fri Apr 14 19:26:29 2023 +0200 add link to child-chain-gauge-factory-v2 (#2434) * add link to child-chain-gauge-factory-v2 * Remove extra blank line Co-authored-by: EndymionJkb <[email protected]> --------- Co-authored-by: EndymionJkb <[email protected]> commit 5ce07faae1ab31f3f02ed85b95416f7f4f3418fa Author: EndymionJkb <[email protected]> Date: Fri Apr 14 12:56:55 2023 -0400 Deployment: Managed Pool V2 (#2435) * initial deployments * update changelog * add outputs to readme * add remaining networks * remove avalanche - incomplete, and causing CI to fail commit f8cf95eb61eeb27275ee33ab147737d4c97e7ea1 Author: EndymionJkb <[email protected]> Date: Thu Apr 13 19:15:09 2023 -0400 refactor: adjust deployment script for new factory (#2433) commit 42964e882e12c03bd4822ba86b513e5f79a5a49b Author: EndymionJkb <[email protected]> Date: Thu Apr 13 17:46:11 2023 -0400 Shorten Managed Pool initialization code (#2432) * refactor: deploy weighted math and recovery mode helper externally * lint * fix: external math deployment commit 3c8d1c07f6f19290bb6a1ec09794ce322203a9ac Author: EndymionJkb <[email protected]> Date: Thu Apr 13 14:30:16 2023 -0400 feat: add mock managed pool deployment (#2429) commit f12b5d2e49f2aaa84aa21ea117d491605bbb8dcf Author: EndymionJkb <[email protected]> Date: Thu Apr 13 12:37:09 2023 -0400 Deployment Preparation (2/2): Managed Pool V2 (#2415) * feat: add baseline deployment task for Managed Pool V2 * Add build-info, artifacts, and update fork test * refactor: artifact checks aren't letting me consolidate library build-info (old version also has them split) * fix: link from deprecated managed pool * test: extend fork test (still WIP) * fix: rename file (+ lint) * fix: reentrancy tests commit 3d7a4382e0f7023602bb3cbd06aaaa73ff9ba9e1 Author: João Bruno Abou Hatem de Liz <[email protected]> Date: Wed Apr 12 16:44:18 2023 -0300 [1/2] Deployment Preparation: Silo Linear Pool Factory V2 (#2423) * Deprecating old Silo Linear Pool and creating new deployment task for Silo LP V2 * Fixing deprecated silo linear pool tests and readme.md * Updating new Silo Linear Pool tests and deployment task * Adding missing information about deprecated task in the new Silo Linear Pool readme.md * Update pkg/deployments/tasks/20230410-silo-linear-pool-v2/readme.md Co-authored-by: EndymionJkb <[email protected]> * Adding new deployment task for Silo in deployments Readme file --------- Co-authored-by: EndymionJkb <[email protected]> commit 68b73d0f5c618e2e7692f83addd2712edd2420af Author: Igor Yalovoy <[email protected]> Date: Wed Apr 12 13:30:40 2023 -0600 Deployment: TimelockAuthorizer (#2427) * CHANGELOG * Fix verification for TimelockAuthorizer * Deployment artifacts * Add Goerli addresses to README * Fix action-ids for Goerli * Update pkg/deployments/action-ids/goerli/action-ids.json Co-authored-by: Nicolás Venturo <[email protected]> * Fix action-ids.json --------- Co-authored-by: Nicolás Venturo <[email protected]> commit 25c505d2167089c99dd6f2c91c1098453d0d2af5 Author: João Bruno Abou Hatem de Liz <[email protected]> Date: Wed Apr 12 16:14:38 2023 -0300 [1/2] Deployment Preparation: Gearbox Linear Pool Factory V2 (#2420) * Deprecating old Gearbox Linear Pool * Creating new deployment folder for Gearbox Linear Pool V2 * Adding deprecated comment to Readme.md * Fixing tests from deprecated pool factory * Removing not created output files from readme.md * Fixing deployments README.md * Fixing broken link * Adding new deployment task for Gearbox in deployments Readme file --------- Co-authored-by: EndymionJkb <[email protected]> commit 3a6b4821c676467f128bdf74aafe094fcd0012b2 Author: EndymionJkb <[email protected]> Date: Wed Apr 12 14:53:58 2023 -0400 docs: format of L2 Layer0 Bridge Forwarder (#2428) commit 39aa1074dcb45e873c0596445071841bc0543903 Author: João Bruno Abou Hatem de Liz <[email protected]> Date: Wed Apr 12 15:51:08 2023 -0300 [1/2] Deployment Preparation: Yearn Linear Pool Factory V2 (#2421) * Deprecating Yearn Linear Pool Factory * Creating deployment task for Yearn Linear Pool Factory V2 * Fixing deprecated tests and readme.md * Adding new deployment task for Yearn in deployments Readme file --------- Co-authored-by: EndymionJkb <[email protected]> commit 5d01538d147e374bc264d8b1776111e457eae550 Author: João Bruno Abou Hatem de Liz <[email protected]> Date: Wed Apr 12 15:23:49 2023 -0300 [1/2] Deployment Preparation: ERC-4626 Linear Pool Factory V4 (#2419) * Moving old ERC4626 Linear Pool to deprecated * Creating new deploymentg for ERC4626LinearPoolFactory * Adding deprecated warning * Fixing tests from deprecated pool factory * Reverting package.json changes * Fixing dead link in previous deprecated version of pool factory * Removing not created artifacts from readme.md * Adding other artifacts to readme.md file * Fixing deployments README.md * Adding new deployment task for ERC-4626 in deployments Readme file * Removing duplicated contracts to test erc4626 linear pool factories * Removing output information from old erc4626 deployment * Adding unchanged output to old ERC4626 deployment task --------- Co-authored-by: EndymionJkb <[email protected]> commit 37d304c74e733ce54af8b0cde24bd3becd011cef Author: EndymionJkb <[email protected]> Date: Wed Apr 12 11:45:14 2023 -0400 Managed Pool bytecode (V1) (#2411) * Split into library * Avoid stack variables * Add missing upscale call --------- Co-authored-by: Nicolás Venturo <[email protected]> commit 920afcb4fea450f59df518369637d6065c88c5fe Author: João Bruno Abou Hatem de Liz <[email protected]> Date: Wed Apr 12 12:24:32 2023 -0300 [1/2] Deployment Preparation: Aave Linear Pool Factory V5 (#2424) * Deprecating Aave Linear Pool V4 and creating deployment test for new Aave Linear Pool * Fixing new deployment task for Aave * Fixing broken link * Including new deployment on readme and specifying Aave version commit c5099fc30ea801e09badd0faabe634710463aa22 Author: Nicolás Venturo <[email protected]> Date: Tue Apr 11 16:33:27 2023 -0300 Do deployment (#2426) commit 0c85ebe7f0420515bc3c81a7e731d898c2526561 Author: Nicolás Venturo <[email protected]> Date: Tue Apr 11 15:32:09 2023 -0300 Add bridge forwarder deployment (#2410) * Add bridge forwarder deployment * Add artifacts * Update build info * Update artifacts commit ec15bb54eeb067979772fd1edc943e8642d87173 Author: Igor Yalovoy <[email protected]> Date: Tue Apr 11 12:17:03 2023 -0600 Deployment Preparation: TimelockAuthorizer (#2394) * Add new timelock deployment * Fix fork tests; Fetch onchain roles * Update build info * Add Goerli fork test * Remove unnecessary build info files * Update pkg/deployments/tasks/20230403-timelock-authorizer/readme.md Co-authored-by: Nicolás Venturo <[email protected]> * Lint; Rename build info * Update artifact * Add Goerli roles from TheGraph * Comments * Obscure links so CI can pass * Disable markdown link checks * Remove dead link * Add TimelockExecutionHelper link * Deprecate old TimelockAuthorizer * Add GOERLI_ARCHIVE_ENDPOINT * Update deprecated task * Update README and CHANGELOG * Update pkg/deployments/tasks/20230403-timelock-authorizer/input.ts Co-authored-by: Nicolás Venturo <[email protected]> * Update pkg/deployments/tasks/20230403-timelock-authorizer/test/task.fork.ts Co-authored-by: Nicolás Venturo <[email protected]> * README * Test mint only on mainnet * Remove getOnChainRoles * Reduce execution delays on Goerli * Rename id to entryId * Remove mainnet test * Reduce delays on Goerli * Add getActionIdInfo function * Add get-action-id-info task * Fix get-action-id-info task * . * Add Goerli JSON permissions * Add graphql * Use goerli.json * Update filenames * Add fetchTheGraphPermissions function * Add get-action-ids-info * Fix link * Lint * Update pkg/deployments/README.md Co-authored-by: EndymionJkb <[email protected]> * Remove old relayers * Not migrate scripts * Cleanup gauge adder * Update goerli.json * Populate goerli action ids (#2422) * Remove process.stdout.write from get-action-ids-info * Delete mainnet input file * Throw an error on missing signature * Add grant delays for change_type_weight and change_gauge_weight * Add grant delay for withdrawCollectedFees * Write to stdout * Set target for the permissions migration * Remove unidentified permissions * Fix goerli.json * Expect target to be set for Vyper contracts * Add 0x placeholders for useAdapter==true permissions * Remove 0x placeholders * Update goerli.json --------- Co-authored-by: Nicolás Venturo <[email protected]> Co-authored-by: EndymionJkb <[email protected]> commit 46de39018467a4a695b112cdc7aa30bfbe29cfd9 Author: EndymionJkb <[email protected]> Date: Tue Apr 11 11:33:09 2023 -0400 feat: add veBAL supply update hook (#2416) commit 2e153af5087293032c319a79bdc33094b82f40fe Author: EndymionJkb <[email protected]> Date: Thu Apr 6 17:00:45 2023 -0400 refactor: cleanup obsolete parameter (#2414) commit 1a313eff3f8ea21ea3d12e2ea8579a45badbc492 Author: EndymionJkb <[email protected]> Date: Wed Apr 5 10:52:14 2023 -0400 Skip failing foundry tests (#2409) * test: skip failing foundry tests * docs: add todo notes commit b3b919775903450c5c3b4d22f1daf14689ce9cb7 Author: Juan Ignacio Ubeira <[email protected]> Date: Tue Apr 4 15:17:54 2023 -0300 Layer Zero (L2) forwarder (#2407) * L2LayerZeroBridgeForwarder. * L2LayerZeroDelegation tests. * use interface * Update interface changelog --------- Co-authored-by: Nicolás Venturo <[email protected]> commit 267048b08e6af9acb5b9943f42c88a915fc25612 Author: Juan Ignacio Ubeira <[email protected]> Date: Tue Apr 4 14:11:02 2023 -0300 Deployment preparation: `VotingEscrowRemapper` (#2406) * veBAL remapper deployment preparation with fork test. * Add artifacts. * Update pkg/deployments/tasks/20230403-vebal-remapper/test/task.fork.ts --------- Co-authored-by: Nicolás Venturo <[email protected]> commit 9b78879ee3a0dcae57094bdfdae973873e4262cf Author: Tom French <[email protected]> Date: Tue Apr 4 00:19:25 2023 +0100 Initial version of VotingEscrowRemapper for cross chain boosts (#2174) commit a725724ab3a1fdde56fbfa0e7be963781ec04dcf Author: EndymionJkb <[email protected]> Date: Mon Apr 3 13:50:48 2023 -0400 Task typo (#2404) * docs: constrcutor typo and light edits * docs: reference deployment transaction commit 8c31059c91a4758840a462400286e8a61b70a375 Author: EndymionJkb <[email protected]> Date: Fri Mar 31 13:57:57 2023 -0400 docs: typo in ci config (#2401) commit 254795923d5f38e11d94491543441f6cd2d1296a Author: EndymionJkb <[email protected]> Date: Fri Mar 31 13:57:35 2023 -0400 refactor: remove unnecessary import (#2400) commit 49e392ce7358652170eea0641eddbee723d6ebec Author: EndymionJkb <[email protected]> Date: Thu Mar 30 15:41:09 2023 -0400 WeightedPool: yield all-time-high update event (#2342) * feat: emit event when the ATHRateProduct is updated * test: check that the event is emitted commit b3cf13574909a2bb33e32a55b987ddd727383dcd Author: EndymionJkb <[email protected]> Date: Thu Mar 30 15:35:57 2023 -0400 Managed Pool: use cash balance only for recovery mode exit (#2298) * fix: use cash balance only for recovery mode exit * refactor: use external RecoveryModeHelper * fix: update MockManagedPoolSettings * fix: pass in helper in ownerOnlyActions test commit 72477c179d78f3736984de12b524e84d5eb84ce8 Author: Juan Ignacio Ubeira <[email protected]> Date: Wed Mar 29 19:14:27 2023 -0300 Deployment: `ChildChainGaugeFactory` (#2387) commit b46023f7c5deefaf58a0a42559a36df420e1639f Author: EndymionJkb <[email protected]> Date: Wed Mar 29 14:49:56 2023 -0400 docs: fix StableMath equation comments (#2392) commit 6f8dc53caf309ada35f61e70ccc83ba10b7a8552 Author: Igor Yalovoy <[email protected]> Date: Wed Mar 29 10:06:13 2023 -0600 Disallow no-op calls for grantPermission, revokePermission, reno… (#2388) * Disallow duplicated calls for grantPermission, revokePermission, renouncePermission * Lint * Fix Exit Pool tests * Fix JoinPool tests * Fix Swaps tests * Fix VaultAuthorization tests * Fix NewBasePool tests * Fix weighted pool tests * Fix tests * lint * Add grantPermissionGloballyIfNeeded function * Update pkg/vault/test/authorizer/TimelockAuthorizerPermissions.test.ts Co-authored-by: Nicolás Venturo <[email protected]> * Update pkg/vault/test/authorizer/TimelockAuthorizerPermissions.test.ts Co-authored-by: Nicolás Venturo <[email protected]> --------- Co-authored-by: Nicolás Venturo <[email protected]> commit 1a3bf53c432150901888fdfd7c47e1f858ab12d5 Author: Igor Yalovoy <[email protected]> Date: Tue Mar 28 11:45:48 2023 -0600 Test that data has function selector (#2389) commit 7f200f9633a1c0a13610034dd20f3423f76b57bd Author: Igor Yalovoy <[email protected]> Date: Mon Mar 27 15:38:31 2023 -0600 Remove reentrancy guard on TimelockAuthorizer (#2385) * Remove reentrancy guard * Apply suggestions from code review Co-authored-by: EndymionJkb <[email protected]> * Update pkg/vault/contracts/authorizer/TimelockAuthorizerManagement.sol Co-authored-by: Nicolás Venturo <[email protected]> --------- Co-authored-by: EndymionJkb <[email protected]> Co-authored-by: Nicolás Venturo <[email protected]> commit 4a3275a9a82ab321740b21025696f33402f1d654 Author: Nicolás Venturo <[email protected]> Date: Fri Mar 24 11:39:57 2023 -0300 Bump and publish v4.0.0 of solidity and pool utils (#2386) * solidity-utils v4.0.0 * pool-utils v4.0.0 commit 7e6caaa059f1dbc78403c2b9388a457d0cc989cb Author: Juan Ignacio Ubeira <[email protected]> Date: Thu Mar 23 17:14:38 2023 -0300 Deployment preparation: `ChildChainGaugeFactory` (#2372) commit 5f7aeacc7c34b2d2833343299ea49a8ec9feb631 Author: Igor Yalovoy <[email protected]> Date: Thu Mar 23 11:42:13 2023 -0600 Split and refactor TimelockAuthorizer tests (#2365) * Split TimelockAuthorizer into multiple files * Rework cancel * Rework execute tests * Refactor schedule tests * More tests * Refactor root tests * Refactor actor tests * Refactor grantPermission * Refactor revokePermission * Refactor revokePermissionGlobally * Refactor revokePermission * Refactor renouncePermission * Test scheduleGrantPermission * Tests for scheduleRevokePermission * Lint * typos * Update pkg/vault/test/authorizer/TimelockAuthorizerActors.test.ts Co-authored-by: Nicolás Venturo <[email protected]> * Refactor removeCanceler/addCanceler * Fix almostEqual * Add schedule tests * Add schedule tests * Test ExecutionScheduled event * Test CANNOT_SCHEDULE_AUTHORIZER_ACTIONS * Test execute return value * More cancel tests * Fix RootChangeScheduled test * Remove unnecessary nesting * More claimRoot tests * Remove misplaced test * Fix and move grantPermission test * Test PermissionGranted event * remove only * Remove unnecessary test * Can renounce even if there is a delay * Test events scheduleRootChange * Better comments * Remove execute tests from schedule tests * Remove execute tests from schedule tests * Add grantPermission test for specific contract * More grantPermission tests * More tests for scheduleGrantPermission * More revokePermission tests * More tests for scheduleRevokePermission --------- Co-authored-by: Nicolás Venturo <[email protected]> commit a399c8057c9f2165079b4cc045e8fb57d4af0018 Author: Nicolás Venturo <[email protected]> Date: Thu Mar 23 08:36:24 2023 -0300 Update .gitignore (#2382) commit 041e0f37e401929f7a8118581b89550dd3330350 Author: EndymionJkb <[email protected]> Date: Wed Mar 22 16:11:03 2023 -0400 Deprecate ComposableStablePool V3 (#2377) * Deprecate ComposableStablePool V3 * Update docs * fix: link merge conflict commit 0fc239b02d3ab0467702d3d4ee4183c02ca8e9ba Author: EndymionJkb <[email protected]> Date: Wed Mar 22 15:37:56 2023 -0400 Deployment: Weighted Pool v4 (#2373) * Deployment to all networks * Add action-ids commit 6a22615f2c55c693a41094343a532f0d857dc6b9 Author: EndymionJkb <[email protected]> Date: Wed Mar 22 15:35:40 2023 -0400 Deprecate Weighted Pool V3 (#2376) * Move weighted-pool v3 to /deprecated * update documentation * docs: remove version comment commit 7e6c21174d858c9b7914d473233a389d3baa451c Author: EndymionJkb <[email protected]> Date: Wed Mar 22 15:20:03 2023 -0400 Deployment: Composable Stable Pool V4 (#2378) * Deploy ComposableStablePoolFactory * Add action ids * remove Avalance output commit 5be54c2e9b4e1a66061a01b463d9ddd7d4437256 Author: Juan Ignacio Ubeira <[email protected]> Date: Wed Mar 22 14:08:37 2023 -0300 Deployment: L2 `VotingEscrowDelegationProxy` (#2375) commit bd44e6a6398021cacc3377ace955c8d8cfd3dc1c Author: Juan Ignacio Ubeira <[email protected]> Date: Wed Mar 22 14:03:17 2023 -0300 Deployment: `L2BalancerPseudoMinter` (#2374) commit 36465b52b6ee8bb4ea0a64c2e33a2baae2dd8ec7 Author: EndymionJkb <[email protected]> Date: Tue Mar 21 15:15:58 2023 -0400 Deployment prep for composable stable pool V4 (#2369) commit 044d443737c2ad89ca0f3f2614298e4c911b3088 Author: Juan Ignacio Ubeira <[email protected]> Date: Tue Mar 21 13:40:13 2023 -0300 Deployment preparation: `VotingEscrowDelegationProxy` for L2s (#2367) commit edee0efaf17ecf1266162ba2d07d18c4918d159e Author: EndymionJkb <[email protected]> Date: Tue Mar 21 10:57:40 2023 -0400 Weighted Pool V4 deployment (#2368) commit 79ea11e2be04ca05a571ca9be540f945f8611678 Author: Nicolás Venturo <[email protected]> Date: Tue Mar 21 11:29:10 2023 -0300 Temporarily disable Gnosis network checks (#2370) commit 197a50201a56e6ddd7dd58ba13dbd020e9c62bf8 Author: Juan Ignacio Ubeira <[email protected]> Date: Mon Mar 20 19:37:39 2023 -0300 Deployment preparation: `L2BalancerPseudoMinter` (#2363) commit 90d9d229d1dc02758ec4c9b065d60b563d32b7bd Author: EndymionJkb <[email protected]> Date: Mon Mar 20 17:08:05 2023 -0400 feat: use create2 in BaseSplitCodeFactory (#2362) feat: update BasePoolFactory feat: update derived pool factories test: update tests refactor: use random instead of zero salts lint fix: adjust benchmark factory creates lint encore test: Test that using the same salt generates the same address test: remove duplicate line docs: add to comment on _create test: allow passing a salt when creating weighted pools lint tests: remove skipped tests tests: remove salt from deployment params docs: shorten comment commit 72e5d0cd0bfeb7b7466596be53ad8db54fb67703 Author: EndymionJkb <[email protected]> Date: Fri Mar 17 14:17:09 2023 -0400 Adjust SiloLinearPool fork test (#2366) * fix: adjust silo fork test * refactor: match task directory name commit 49b6984dd6a8abe919ba080ecc96811364674c21 Author: baileyspraggins <[email protected]> Date: Fri Mar 17 10:39:38 2023 -0500 Deployment Preparation - SiloLinearPoolFactory (#2364) * Silo Linear Pool Deployment Prep * Silo deployment prep edits * Add DO NOT USE for mocks * Fix dependency issue * lint fix commit a8c893835930451d2c5e4a3a74f11ffb2edc044e Author: Juan Ignacio Ubeira <[email protected]> Date: Thu Mar 16 12:42:06 2023 -0300 Improve `ChildChainGauge` constructor. (#2360) commit c42ed0beb8bec46804b3dfc1ae3ea3e977116c41 Author: Igor Yalovoy <[email protected]> Date: Wed Mar 15 16:16:49 2023 -0600 Split TimelockAuthorizer into TimelockAuthorizer and TimelockAuthorizerManagement (#2349) * Split TimelockAuthorizer into TimelockAuthorizer and TimelockAuthorizerManagement * Lint * Move events * Move consts * Lint * Add TimelockAuthorizerManagement interface * More comments * Split ITimelockAuthorizer inteface * Update pkg/vault/contracts/authorizer/TimelockAuthorizerManagement.sol Co-authored-by: Nicolás Venturo <[email protected]> * Update pkg/vault/contracts/authorizer/TimelockAuthorizerManagement.sol Co-authored-by: Nicolás Venturo <[email protected]> * Update pkg/vault/contracts/authorizer/TimelockAuthorizerManagement.sol Co-authored-by: Nicolás Venturo <[email protected]> * Add events * Remove events * Remove events * Fix SENDER_IS_NOT_EXECUTION_HELPER issue * Fix tests * Use only ITimelockAuthorizer; Add consts to the interface * Use @inheritdoc for implementatino NatSpec * Fix inheritdoc * Fix const naming * Merge with master --------- Co-authored-by: Nicolás Venturo <[email protected]> commit 704bdaadee3cff29b6449364bd4bb67592b61ef6 Author: EndymionJkb <[email protected]> Date: Wed Mar 15 17:40:09 2023 -0400 Deployment: Batch Relayer V5 (#2358) * feat: Batch Relayer V5 deployment * feat: add actionIds * refactor: batch-relayer-action-id-ectomy * docs: remove reference in the action-id checker commit 4e01edc4ad8727b5e26fe764a4cce7ac1da99e14 Author: Nicolás Venturo <[email protected]> Date: Wed Mar 15 18:38:33 2023 -0300 Publish interfaces v0.4.0 (#2361) * v0.4.0 * Update pkg/interfaces/CHANGELOG.md Co-authored-by: EndymionJkb <[email protected]> --------- Co-authored-by: EndymionJkb <[email protected]> commit f5730198a822cb639aa9e014efa6d94e9034d9a0 Author: EndymionJkb <[email protected]> Date: Wed Mar 15 09:55:31 2023 -0400 refactor: clarify process for addressing actionId collisions (#2359) commit 647b5fcbde1d824b762bcb49d856cc7ca5af5d7b Author: Igor Yalovoy <[email protected]> Date: Tue Mar 14 18:18:31 2023 -0600 Do not allow repeated executors (#2357) * Do not allow repeated executors * Update pkg/vault/contracts/authorizer/TimelockAuthorizer.sol Co-authored-by: Nicolás Venturo <[email protected]> * Fix --------- Co-authored-by: Nicolás Venturo <[email protected]> commit 4da9e281fb9907cdac433aaaa2e4172090204b4f Author: Juan Ignacio Ubeira <[email protected]> Date: Tue Mar 14 18:29:17 2023 -0300 Remove auth from `checkpoint`; improve error messages. (#2352) * Individual checkpoints for child chain gauge. * Fix comment. * `ChildChainGauge` tests (#2350) * Fix tests with new deps. * Improve index checking. * Prevent setting BAL as a reward token in `ChildChainGauge`. (#2332) * Prevent setting BAL as a reward token in `ChildChainGauge`. * Add test. * Remove `async` for `almostEqual` (array case). (#2354) * Improve tests. * Address comments (1). * Test with some (not all) rewards. * Add broken reward test. * Add test. * Remove auth from `checkpoint`; improve error messages. * Add checkpoint by other test. commit eaa922d62a8e0831004acf82afa9c3a9c4b945db Author: Juan Ignacio Ubeira <[email protected]> Date: Tue Mar 14 18:23:10 2023 -0300 Individual checkpoints for `ChildChainGauge` rewards (#2325) * Individual checkpoints for child chain gauge. * Fix comment. * `ChildChainGauge` tests (#2350) * Fix tests with new deps. * Improve index checking. * Prevent setting BAL as a reward token in `ChildChainGauge`. (#2332) * Prevent setting BAL as a reward token in `ChildChainGauge`. * Add test. * Remove `async` for `almostEqual` (array case). (#2354) * Improve tests. * Address comments (1). * Test with some (not all) rewards. * Add broken reward test. * Add flaky reward test. * Nit. commit acdcc3480f4bbed9f418c9920cf4217f2eed0d72 Author: EndymionJkb <[email protected]> Date: Tue Mar 14 11:44:12 2023 -0400 Deployment preparation: Batch Relayer V5 (#2345) * chore: deprecate batch-relayer-v4 * chore: update top level readme, moving from batch relayer V4 to V5 * feat: create new task for batch-relayer-v5 * chore: update CHANGELOG with deprecation * feat: add BatchRelayerLibrary deployment script and build-info * feat: add fork tests * fix: missing artifact link * fix: remove outputs (not yet!) * fix: link to previously deprecated relayer * fix: deprecated fork test link * refactor: remove stable pool tests out of primary test; will go in their own files * docs: clarify status of phantom stable pools * update build-info * update artifact * feat: add remaining fork tests * refactor: share common stable pool parameters * feat: add compound fork test * fix: remove only * feat: add PoolKind enum to tell the relayer what kind of pool it is * refactor: update fork tests to use the relayer * refactor: switch networks to avoid needed a BSC archive node * docs: preface new CHANGELOG entries with unreleased header * tests: remove redundant describe block * tests: remove redundant describe blocks in fork tests * tests: pull BPT from owner in V1 fork test * docs: remove non-relayer exit comments * tests: remove non-relayer "example" tests * lint; don't send tokens through relayer * tests: remove dependency on external build info * refactor: don't store tokens in the relayer commit 6f63714dc7361432bdad9f7b263221b55863671b Author: Juan Ignacio Ubeira <[email protected]> Date: Tue Mar 14 11:22:19 2023 -0300 Remove `async` for `almostEqual` (array case). (#2354) commit eeb691ef904b8de4569f7bdfa06acce8c8af07cb Author: Nicolás Venturo <[email protected]> Date: Fri Mar 10 15:20:48 2023 -0300 Fix Linear import (#2347) commit 58831a59fc107834e69277c4e09426930abe2226 Author: Nicolás Venturo <[email protected]> Date: Fri Mar 10 15:20:34 2023 -0300 Fix flaky test (#2348) commit 322e72bab69beaa7eb7626eda78242b6be49fe00 Author: Nicolás Venturo <[email protected]> Date: Fri Mar 10 12:32:26 2023 -0300 Improve schedule delay change docs (#2338) * Improve schedule delay change docs * Fix linter * Apply suggestions from code review Co-authored-by: Igor Yalovoy <[email protected]> --------- Co-authored-by: Igor Yalovoy <[email protected]> commit b19f38fccfd05e5ce04e1da9424a9110624c6932 Author: EndymionJkb <[email protected]> Date: Fri Mar 10 10:31:18 2023 -0500 feat: also fix warnings in the deployment package (#2344) commit f42351119b8b6270f22cec87417faf426d78c661 Author: EndymionJkb <[email protected]> Date: Thu Mar 9 19:16:19 2023 -0500 Batch Relayer: make deployable (#2339) * refactor: share common code between protocol wrappers to reduce bytecode size * refactor: use shared functions in CompoundV2 * refactor: use shared functions in ERC4626 * refactor: use shared functions in Euler * refactor: use shared functions in GaugeActions * refactor: use shared functions in Gearbox * refactor: use shared functions in Lido * refactor: use shared functions in Reaper * refactor: use shared functions in Silo * refactor: use shared functions in Tetu * refactor: use shared functions in Unbutton * refactor: use shared functions in Yearn * docs: remove commented-out code * docs: add documentation to IBaseRelayerLibrary * refactor: rename _resolveAmountPullAndApproveToken to reflect that the spender is not always a token * refactor: propagate _resolveAmountPullAndApproveToken to the wrappers * refactor: adjust signature to avoid coercion to token types * docs: add dev block * docs: adjust comments to match signature commit 87da3342e91593a659599fbbf27ba86401daf37f Author: Igor Yalovoy <[email protected]> Date: Thu Mar 9 13:41:35 2023 -0600 add shared before each (#2343) commit 1190c6598ef8647f0f2c79e8650846f3cc10eb14 Author: Igor Yalovoy <[email protected]> Date: Thu Mar 9 13:22:55 2023 -0600 Remove batching from grantPermissions, revokePermissions, and renouncePermissions (#2337) * Remove batching from grantPermissions, revokePermissions, and renouncePermissions * Fix tests * Fix tests * lint * Apply suggestions from code review --------- Co-authored-by: Nicolás Venturo <[email protected]> commit 6ee65c60fdf33611c2a758372aba0bf5bb45ae74 Author: Igor Yalovoy <[email protected]> Date: Thu Mar 9 10:16:52 2023 -0600 Remove warnings from linter (#2341) * Remove warnings from linter * Remove warning in packages * Remove warnings at lint:typescipt commit e40ed677d0f5c2d7e58f2d8c239580e4ddd8a356 Author: EndymionJkb <[email protected]> Date: Wed Mar 8 21:09:21 2023 -0500 Batch Relayer: explicit support for Stable Pools (#2308) * feat: extend VaultActions to stable pools * lint * docs: explain factored out private function * feat: support all variants of stable pools * test: add stable pool tests (still need work) * refactor: fix most failing tests * fix: insufficient balance; join for less BPT * fix: adjust deltas for composable indices * docs: also show weighted * test: add unhandled pool types * refactor: use explicit (onchain) version numbers for PoolKinds * refactor: explicit return in _replacedAmounts * docs: clarify stable join replacements, and add docs for top-level replacement functions * refactor: compute exitKind in specific "replacements" functions * fix: reverts should reference Pool, not Join/Exit kinds. Only used here; tests revert with low level call, so just use regular revert * docs: clarify sharing of recoding functions * test: factor out common code, and split stable tests into a separate file * refactor: rename for clarity * lint * docs: fix version reference * docs: distribute stable exit documentation closer to where the logic lives * refactor: do not default PoolKind * refactor: rename top-level describe * lint * refactor: use randomAddress for the recipient, vs reusing user * refactor: do not share sender between tests commit d44d7c29cf8277898aa05759916dc6aa0fe7499e Author: Juan Ignacio Ubeira <[email protected]> Date: Wed Mar 8 18:40:51 2023 -0300 Refactor: voting escrow --> voting escrow delegation proxy in `ChildChainGauge`. (#2333) commit f9c41c3f628de90a3ae7c8470dc7df61bea666fc Author: Juan Ignacio Ubeira <[email protected]> Date: Wed Mar 8 17:51:43 2023 -0300 Improve readme: suggested Node version (#2336) commit 7a84a5f6346768e7dc2a439ce8cad86c11b1e4b5 Author: rabmarut <[email protected]> Date: Wed Mar 8 15:04:26 2023 -0500 Batch Relayer: Compound v2 (#2334) * Midas BatchRelayer * `style`: switch wording * `test`: add fork tests * `refactor`: `ICFuseToken` inherits from `IERC20` * `test`: adapt tests to Interface changes * `fix`: Balance not BalanceDif & handle redeem value * `style`: unify expectTransferEvent address checks * `refactor`: remove midas deployments folder * `refactor`: change of name and types * `feat:` add exchangeRate possibilities * `style`: use TypesConverter * `lint` * `test`: add exitPool * `refactor`: repurpose for CompoundV2 * refactor: rename test Compound -> CompoundV2 * fix: remove unused library * style: clarify comments * fix: use SafeERC20 * style: make `underlying` private * refactor: remove redundant interface file * style: tidy up comments, use @inheritdoc * fix: remove unused variable * feat: incorporate Compound-style decimal scaling * style: tidy comments, change var names * style: lint * docs: add link to ErrorReporter * test: use WeightedPool instead of StablePool * style: clean up error code links and comments --------- Co-authored-by: mkflow27 <[email protected]> Co-authored-by: Sebastian Marquardt <[email protected]> commit 99fe4856e0245d39c2cd0e61c28af928145504d8 Author: mkflow27 <[email protected]> Date: Wed Mar 8 19:58:50 2023 +0100 Euler batch relayer (#2327) * add euler-wrapping capabilities to batch-relayer * preliminary progress on EulerWrapping * `EulerWrapping` to work with actual balances * add `almostEqual` assertion * lint & cleanup * handle withdraw flow on mockEulerProtocol * new build info & cleanup * `refactor`: IEulerToken inherits from IERC20 * `test`: adjust tests to IERC20 inheritance * `test`: Add constructor args due to Euler addition * `test`: Add constructor args due to Euler addition * `style`: lint & remove unnecessary import * `refactor`: remove batch-relayer deployment task * `refactor`: remove batch-relayer deployment task * `refactor`: add FixedPointMath & cleanup * `style`: use TypesConverter in expectTransferEvent * `fix`: add token burn event * `refactor`: remove private var and compiler warning * `feat`: allow higher exchangeRates * `feat`: allow user to specify amount to withdraw * `docs`: improve documentation clarity * `test`: add exitPool * `refactor:` use safeTransfer * `refactor`: change max uint256 representation * `test`: args to account for relayer constructor * `lint`: lint * `lint`: lint * `feat`: allow passing of euler for relayer approval * `refactor`: change tests for relayer constructor * `lint`: move link outside NatSpec * `test`: remove not required arg commit d46ffcf1bbd17288c03bf17a4a5264f0c1f32a50 Author: Igor Yalovoy <[email protected]> Date: Wed Mar 8 09:03:43 2023 -0600 Better self scheduling (#2326) * Inline _schedule * Add specific events for scheduled actions for more clarity * Remove `actionId` from _scheduleWithDelay * Update events at helpers * Use plain `actionId` for `scheduleDelayChange` * Update pkg/vault/contracts/authorizer/TimelockAuthorizer.sol Co-authored-by: Nicolás Venturo <[email protected]> * Update pkg/vault/contracts/authorizer/TimelockAuthorizer.sol Co-authored-by: Nicolás Venturo <[email protected]> * Update pkg/vault/contracts/authorizer/TimelockAuthorizer.sol Co-authored-by: Nicolás Venturo <[email protected]> * More explicit events args for Authorizer * Lint --------- Co-authored-by: Nicolás Venturo <[email protected]> commit 4570a029a50591b06e583d07133bf6941fc1d208 Author: Juan Ignacio Ubeira <[email protected]> Date: Wed Mar 8 09:52:43 2023 -0300 `BalancerMinter` tests. (#2322) commit cf2858ed419e78709d31d633ed321afe15fcd4f0 Author: EndymionJkb <[email protected]> Date: Tue Mar 7 22:15:16 2023 -0500 Reentrancy Preparation: Managed Pool (#2296) * fix: address reentrancy in ManagedPool, and update docs * fix: directly protect protocol fee cache updates * lint * docs: clarify comments * docs: note that ManagedPool itself is protected (though I suppose derived contracts could still be written to be vulnerable) commit 0714602a2a42d933c4c5a6139a9e70547c2714b2 Author: João Bruno Abou Hatem de Liz <[email protected]> Date: Tue Mar 7 23:36:36 2023 -0300 Batch Relayer: Tetu (#2318) * Adding Tetu batch relayer * Adapting withdraw and deposit functions to don`t need to calculate rate in multiple places * Fixing tetu batch relayer tests * Removing "only" from test * Fixing StablePoolEncoder on tests * Refactoring mock of unwrap token to use safeTransferFrom * Fork test setup * Tetu batch relayer fork tests * Fixing Tetu Relayer * Removing deployment task from Tetu Batch Relayer PR * Organizing Tetu Wrapping test * Change burn function from test token to don`t collide with existing burn function from ERC20Burnable contract * Implementing exit pool test for Tetu Wrapping * Fixing tetu wrapping logic to remove reentrancy issue * Removing TetuController * Update pkg/standalone-utils/contracts/relayer/TetuWrapping.sol Co-authored-by: rabmarut <[email protected]> * Update pkg/standalone-utils/contracts/relayer/TetuWrapping.sol Co-authored-by: rabmarut <[email protected]> * Fixing deposit function for Tetu Wrapping * Fixint Tetu Wrapping tests after deposit function was modified * Replacing safeTransferFrom to safeTransfer * Fixing setRate function in the mocked Tetu's smart vault * Removing ExternalCallLib from relayer library * Overriding mint and burn functions of Tetu's token vault, so that balances are always recalculated and rate is adjusted to new total supply * Update pkg/standalone-utils/contracts/relayer/TetuWrapping.sol Co-authored-by: rabmarut <[email protected]> * Update pkg/standalone-utils/contracts/relayer/TetuWrapping.sol Co-authored-by: rabmarut <[email protected]> * Fixing _fromTetu and _toTetu functions * Fixing Tetu Wrapping * Update pkg/standalone-utils/contracts/relayer/TetuWrapping.sol Co-authored-by: rabmarut <[email protected]> * Update pkg/standalone-utils/contracts/test/MockTetuSmartVault.sol Co-authored-by: rabmarut <[email protected]> * Update pkg/standalone-utils/contracts/test/MockTetuSmartVault.sol Co-authored-by: rabmarut <[email protected]> * Update pkg/standalone-utils/contracts/relayer/TetuWrapping.sol Co-authored-by: rabmarut <[email protected]> * Removing casts of ITetuSmartVault (using token instead of address) * Removing address from IERC20 casting, since ITetuSmartVault inherits IERC20 * Removing not necessary cast to IERC20 * Fix Lint * Update pkg/standalone-utils/contracts/relayer/special/TetuShareValueHelper.sol Co-authored-by: EndymionJkb <[email protected]> * Moving mock library to correct folder --------- Co-authored-by: baileyspraggins <[email protected]> Co-authored-by: rabmarut <[email protected]> Co-authored-by: EndymionJkb <[email protected]> commit b5b12399c8805d28ca593938895d518983cc5af0 Author: baileyspraggins <[email protected]> Date: Tue Mar 7 16:56:07 2023 -0600 Batch relayer: Silo (#2328) * Silo wrapping added to relayer * Silo Wrapping tests * Silo wrapping tests * Removed unneeded files and dependencies * Silo Wrapping fork testing * Silo Wrapping withdraw edits * Removing duplicated wrapped token from Silo fork test * Using shar…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add reentrancy protection for Managed Pool. This is a new release, not a patch, so it is based off master.
Type of change
Checklist:
master, or there's a description of how to mergeIssue Resolution
Closes #2295