Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address lookup review comments #2074

Merged
merged 3 commits into from
Nov 29, 2022
Merged

Address lookup review comments #2074

merged 3 commits into from
Nov 29, 2022

Conversation

TomAFrench
Copy link
Contributor

Description

Adds some commits addressing review comments on #2031 which weren't pushed before merging.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

@TomAFrench TomAFrench requested a review from nventuro November 28, 2022 21:29
nventuro
nventuro reviewed Nov 28, 2022
View reviewed changes
pkg/deployments/index.ts Outdated Show resolved Hide resolved
@TomAFrench TomAFrench requested a review from nventuro November 29, 2022 20:48
@TomAFrench TomAFrench merged commit cd16d44 into master Nov 29, 2022
@TomAFrench TomAFrench deleted the address-lookup-review branch November 29, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nventuro nventuro nventuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomAFrench @nventuro