Improve AuthorizerAdaptorEntrypoint docs #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EndymionJkb
reviewed
Nov 11, 2022
EndymionJkb
reviewed
Nov 11, 2022
EndymionJkb
reviewed
Nov 11, 2022
pkg/liquidity-mining/contracts/admin/AuthorizerAdaptorEntrypoint.sol
Outdated
Show resolved
Hide resolved
EndymionJkb
reviewed
Nov 11, 2022
EndymionJkb
reviewed
Nov 11, 2022
There was a problem hiding this comment.
Technically the new error message could be separate, but it is related. We have other tests for invalid data that check for "Transaction reverted without a reason"; could call it INVALID_DATA and use it for those cases too. Or say INVALID_CALLDATA / MALFORMED_CALLDATA to differentiate between explicit calldata and general encoded data.
jubeira
approved these changes
Nov 11, 2022
pkg/liquidity-mining/contracts/admin/AuthorizerAdaptorEntrypoint.sol
Outdated
Show resolved
Hide resolved
Co-authored-by: EndymionJkb <[email protected]>
dandamiangow3t
pushed a commit
to IlluviumGame/balancer-v2-monorepo
that referenced
this pull request
May 10, 2023
* Add AuthorizerAdaptor docs and warnings * Small test adjustment * Adjust authorizer comments * Clarify action ids matching * Minor adaptor comment update * Adjust entrypoint comments * Apply suggestions from code review Co-authored-by: EndymionJkb <[email protected]> Co-authored-by: EndymionJkb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This goes into much more detail as to what the issue is and how the fix works in all components involved, so that a reader that stumbles on any of them will get sufficient context to understand the full picture.
Type of change
Checklist:
master, or there's a description of how to merge