Feat add pool with hook consider flag #1142
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d200415 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -66,6 +66,7 @@ export class SorService { | |||
| wethIsEth: wethIsEth, | |||
| } | |||
| : undefined, | |||
| considerPoolsWithHooks: args.considerPoolsWithHooks ? args.considerPoolsWithHooks : false, | |||
There was a problem hiding this comment.
This works, but just sharing that there are simpler ways of doing this, such as:
args.considerPoolsWithHooks ?? false // this returns the first argument if defined, otherwise false
or
!!args.considerPoolsWithHooks // this is called falsy, which returns false if undefined
| @@ -391,7 +391,7 @@ export const prismaPoolBatchSwapWithSwaps = Prisma.validator<Prisma.PrismaPoolBa | |||
|
|
|||
| export type PrismaPoolBatchSwapWithSwaps = Prisma.PrismaPoolBatchSwapGetPayload<typeof prismaPoolBatchSwapWithSwaps>; | |||
|
|
|||
| export const prismaPoolWithDynamic = Prisma.validator<Prisma.PrismaPoolArgs>()({ | |||
| export const prismaPoolWithDynamicAndHook = Prisma.validator<Prisma.PrismaPoolArgs>()({ | |||
There was a problem hiding this comment.
I'd say prismaPoolAndHookWithDynamic follows the existing pattern a bit better.
@franzns - since this is more of a backend/db thing than an SOR thing, do you have a preference?
| )) as PathWithAmount[]; | ||
| expect(paths.length).toBeGreaterThan(0); | ||
| }); | ||
| test('SOR does not consider pools with hooks - when hook available', async () => { |
There was a problem hiding this comment.
These tests are not yet done, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds optionality for pools with hooks to be either considered or not considered when the api uses the sor