This repository has been archived by the owner on Oct 26, 2021. It is now read-only.
Ramp Instant - Buy ETH/DAI #490
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 Preview this pull request. Built with commit 4cae283 |
0ex-d
suggested changes
May 20, 2021
| onBuy = () => { | ||
| let widget = new RampInstantSDK({ | ||
| hostAppName: 'Balance Manager', | ||
| hostLogoUrl: `https://localhost:3000${balanceManagerLogo}`, |
| <StyledIcon color="grey" icon={arrowUp} /> | ||
| {lang.t('modal.buy_title', { | ||
| walletName: capitalize( | ||
| `${this.props.accountType}${lang.t('modal.default_wallet')}`, |
There was a problem hiding this comment.
Repetitive use of this.props. I suggest you destructure props.
| left | ||
| isModalButton | ||
| color="blue" | ||
| disabled={!Number(this.props.assetAmount)} |
There was a problem hiding this comment.
Incomplete logic. What if assetAmount is 0?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog