Skip to content

Commit

Permalink
Restored skipped Container Node Pool tests (GoogleCloudPlatform#10126)
Browse files Browse the repository at this point in the history
  • Loading branch information
shuyama1 authored and balanaguharsha committed May 2, 2024
1 parent b1b0160 commit 03d3777
Showing 1 changed file with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,6 @@ func TestAccContainerNodePool_withSandboxConfig(t *testing.T) {
<% end -%>

func TestAccContainerNodePool_withKubeletConfig(t *testing.T) {
t.Skipf("Skipping test %s due to https://github.com/hashicorp/terraform-provider-google/issues/16064", t.Name())
t.Parallel()

cluster := fmt.Sprintf("tf-test-cluster-%s", acctest.RandString(t, 10))
Expand All @@ -528,7 +527,7 @@ func TestAccContainerNodePool_withKubeletConfig(t *testing.T) {
CheckDestroy: testAccCheckContainerClusterDestroyProducer(t),
Steps: []resource.TestStep{
{
Config: testAccContainerNodePool_withKubeletConfig(cluster, np, "static", "100us", networkName, subnetworkName, true, 2048),
Config: testAccContainerNodePool_withKubeletConfig(cluster, np, "static", "100ms", networkName, subnetworkName, true, 2048),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("google_container_node_pool.with_kubelet_config",
"node_config.0.kubelet_config.0.cpu_cfs_quota", "true"),
Expand Down Expand Up @@ -858,7 +857,6 @@ func TestAccContainerNodePool_withBootDiskKmsKey(t *testing.T) {
<% end -%>

func TestAccContainerNodePool_withUpgradeSettings(t *testing.T) {
t.Skipf("Skipping test %s due to https://github.com/hashicorp/terraform-provider-google/issues/16064", t.Name())
t.Parallel()

cluster := fmt.Sprintf("tf-test-cluster-%s", acctest.RandString(t, 10))
Expand Down

0 comments on commit 03d3777

Please sign in to comment.