Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete ignored keys from diff #510

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Delete ignored keys from diff #510

merged 5 commits into from
Jul 9, 2024

Conversation

disrupted
Copy link
Member

Closes #508

@disrupted disrupted self-assigned this Jul 9, 2024
@disrupted disrupted marked this pull request as ready for review July 9, 2024 12:05
@disrupted disrupted requested a review from raminqaf as a code owner July 9, 2024 12:05
@disrupted disrupted merged commit ae894d1 into main Jul 9, 2024
17 of 18 checks passed
@disrupted disrupted deleted the feat/helm-diff-del-ignored-key branch July 9, 2024 14:48
@disrupted disrupted added type/enhancement New feature or request component/handlers Related to component handlers labels Jul 9, 2024
@DerTiedemann DerTiedemann mentioned this pull request Jul 12, 2024
Merged
@DerTiedemann DerTiedemann mentioned this pull request Jul 29, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raminqaf raminqaf raminqaf approved these changes

Assignees

@disrupted disrupted

Labels
component/handlers Related to component handlers type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm diff should not print old value if field is ignored
2 participants
@disrupted @raminqaf