Generate changelog for releases #84
Conversation
| configuration: "${{ inputs.config }}" | ||
| fromTag: "${{ inputs.old-tag }}" | ||
| toTag: "${{ inputs.new-tag }}" | ||
| outputFile: "${{ inputs.output }}" |
There was a problem hiding this comment.
It seems like this action has a number of output, among others outputs.changelog. Can we also use an output instead of writing it to a temporary file?
There was a problem hiding this comment.
So you mean something like this then?
echo "changelog=${{ steps.build_changelog.outputs.changelog }}" >> "$GITHUB_OUTPUT"
There was a problem hiding this comment.
Yes, the temporary file was only a workaround. I think using the output is much cleaner because we have one less parameter and users don't need to worry that we add a file that they might accidentally commit and push
There was a problem hiding this comment.
@torbsto @yannick-roeder @raminqaf
in order to modify this the generate Changelog before adding it to the main Changelog, we need to store it in a tmp file.
However, if we do not wish to change the Changelog file in this composite action and want to return the raw Changelog instead, then we do not need a composite action at all. because the used action already does that.
There was a problem hiding this comment.
@MichaelKora @yannick-roeder Just to clarify, I do want to update the changelog file, but I also need the generated changelog for the GitHub release later on, for example in Quick:
|
I'm closing this PR since there's no persuasive reason to add any new features to the existing one. |
Fixes #8