Fix getters/setters visibility. Constructor arguments optional

baikunz · Apr 6, 2013 · 3b7aa72 · 3b7aa72
1 parent 674c470
commit 3b7aa72
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 15 deletions.
diff --git a/src/Shuble/Slurpy/Operation/BackgroundOperation.php b/src/Shuble/Slurpy/Operation/BackgroundOperation.php
@@ -24,7 +24,7 @@ class BackgroundOperation extends BaseOperation
      * @param string $backgroundFile Path to the background file
      * @param string $multi          Whether the background operation is multi or not
      */
-    public function __construct($backgroundFile, $multi = false)
+    public function __construct($backgroundFile = null, $multi = false)
     {
         $this->backgroundFile = $backgroundFile;
         $this->multi = $multi;
@@ -58,7 +58,7 @@ public function getArguments()
      *
      * @return BackgroundOperation
      */
-    protected function setMulti($multi)
+    public function setMulti($multi)
     {
         $this->multi = (boolean) $multi;
 
@@ -70,7 +70,7 @@ protected function setMulti($multi)
      *
      * @return boolean
      */
-    protected function getMulti()
+    public function getMulti()
     {
         return $this->multi;
     }
@@ -82,7 +82,7 @@ protected function getMulti()
      *
      * @return BackgroundOperation
      */
-    protected function setBackgroundFile($backgroundFile)
+    public function setBackgroundFile($backgroundFile)
     {
         $this->backgroundFile = $backgroundFile;
 
@@ -94,7 +94,7 @@ protected function setBackgroundFile($backgroundFile)
      *
      * @return string
      */
-    protected function getBackgroundFile()
+    public function getBackgroundFile()
     {
         return $this->backgroundFile;
     }

diff --git a/src/Shuble/Slurpy/Operation/StampOperation.php b/src/Shuble/Slurpy/Operation/StampOperation.php
@@ -24,7 +24,7 @@ class StampOperation extends BaseOperation
      * @param string $stampFile Path to the stamp file
      * @param string $multi     Whether the stamp operation is multi or not
      */
-    public function __construct($stampFile, $multi = false)
+    public function __construct($stampFile = null, $multi = false)
     {
         $this->stampFile = $stampFile;
         $this->multi = $multi;
@@ -58,7 +58,7 @@ public function getArguments()
      *
      * @return StampOperation
      */
-    protected function setMulti($multi)
+    public function setMulti($multi)
     {
         $this->multi = (boolean) $multi;
 
@@ -70,7 +70,7 @@ protected function setMulti($multi)
      *
      * @return boolean
      */
-    protected function getMulti()
+    public function getMulti()
     {
         return $this->multi;
     }
@@ -82,7 +82,7 @@ protected function getMulti()
      *
      * @return StampOperation
      */
-    protected function setStampFile($stampFile)
+    public function setStampFile($stampFile)
     {
         $this->stampFile = $stampFile;
 
@@ -94,7 +94,7 @@ protected function setStampFile($stampFile)
      *
      * @return string
      */
-    protected function getStampFile()
+    public function getStampFile()
     {
         return $this->stampFile;
     }

diff --git a/src/Shuble/Slurpy/Operation/UpdateInfoOperation.php b/src/Shuble/Slurpy/Operation/UpdateInfoOperation.php
@@ -23,7 +23,7 @@ class UpdateInfoOperation extends BaseOperation
      *
      * @param boolean $utf8 Whether the data input file is utf8 encoded or not
      */
-    public function __construct($dataFile, $utf8 = false)
+    public function __construct($dataFile = null, $utf8 = false)
     {
         $this->dataFile = $dataFile;
         $this->utf8 = $utf8;
@@ -57,7 +57,7 @@ public function getArguments()
      *
      * @return UpdateInfoOperation
      */
-    protected function setDataFile($dataFile)
+    public function setDataFile($dataFile)
     {
         $this->dataFile = $dataFile;
 
@@ -69,7 +69,7 @@ protected function setDataFile($dataFile)
      *
      * @return string
      */
-    protected function getDataFile()
+    public function getDataFile()
     {
         return $this->dataFile;
     }
@@ -81,7 +81,7 @@ protected function getDataFile()
      *
      * @return UpdateInfoOperation
      */
-    protected function setUtf8($utf8)
+    public function setUtf8($utf8)
     {
         $this->utf8 = (boolean) $utf8;
 
@@ -93,7 +93,7 @@ protected function setUtf8($utf8)
      *
      * @return boolean
      */
-    protected function getUtf8()
+    public function getUtf8()
     {
         return $this->utf8;
     }