补齐query_result中的choices字段 #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Alex-TG001
commented
Oct 29, 2024
Alex-TG001
commented
- Description: 新增choices的content合并
- Issue:
- Dependencies:
- Tag maintainer: @stonekim, @danielhjz, @ZingLix @Dobiichi-Origami.
| if "delta" in stream_json: | ||
| content = stream_json["delta"].get("content", "") | ||
| merged_query += content | ||
| if index not in res_choices: |
There was a problem hiding this comment.
这段逻辑的兼容性不够
- 不能预设头包中就包含了所有会出现的字段
- 不能假设字段是固定的，到时候有 Diff 就爆炸
Dobiichi-Origami
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.