Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update qa tests with fixed cases #478

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Update qa tests with fixed cases #478

merged 1 commit into from
Aug 19, 2024

Conversation

wolvever
Copy link
Contributor

  1. Remove util and config import, which is not used
  2. Fix test class name conflicts
  3. Add more meaningful asserts
  4. Simplify test cases with one normal routine only.

MrChengmo
MrChengmo approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@MrChengmo MrChengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrChengmo MrChengmo merged commit 306fd17 into baidubce:master Aug 19, 2024
2 of 3 checks passed
@wolvever wolvever deleted the update_qa_tests branch August 19, 2024 15:44
C9luster pushed a commit to C9luster/app-builder that referenced this pull request Sep 4, 2024
@wolvever
Update qa tests with fixed cases (baidubce#478)
f7751a1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrChengmo MrChengmo MrChengmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolvever @MrChengmo