Fix pinging the server when it listens on 0.0.0.0 and the user provided the port number #357

bahmutov · 2023-02-24T18:18:14Z

Replace assuming the port XXXX refers to localhost:XXXX and instead use 127.0.0.1:XXXX

closes start-server-and-test failure wait for localhost of react-app Node.js 18 #356
closes Next.js server start hangs #348
closes Node 17 support #333

bahmutov · 2023-02-24T19:23:41Z

@MikeMcC399 what do you think about this solution? I wish I could try pinging both localhost:XXXX and 127.0.0.1:XXXX alternatively but since we rely on wait-on, we cannot do this. I am also thinking this should be a "minor" version bump.

MikeMcC399 · 2023-02-26T17:45:03Z

@bahmutov

I tried this fix with start-server-and-test failure wait for localhost of react-app Node.js 18 #356 and it did not solve the issue. In this issue the hostname localhost is specified, so it does not rely on wait-on assuming a default hostname.
The wait-on issue wait-on perpetually returns ECONNREFUSED when using localhost, but works fine using 127.0.0.1 jeffbski/wait-on#109 is unresolved, although there has been a fork https://github.com/metcoder95/wait-on created where the issue is resolved. The owner of the fork reports that he implemented "Happy Eyeballs" (see feat(tcp): happy eyeballs support metcoder95/wait-on#20).
I didn't understand your sentence "The latest versions of Node and some web servers listen on host 0.0.0.0 which no longer means localhost." and I am not sure if it is a correct explanation. What I saw in the react-scripts example is that the web server was listening on 0.0.0.0 (meaning all addresses), dns was resolving localhost to 127.0.0.1 and ::1 then wait-on tried to test the localhost IPv6 ::1 on Node.js 18 and the web server did not respond.

bahmutov · 2023-02-26T17:55:49Z

Ok so the solution is to use explicit host and maybe put a warning when someone uses just a port Sent from my iPhoneOn Feb 26, 2023, at 12:45, Mike McCready ***@***.***> wrote: @bahmutov I tried this fix with #356 and it did not solve the issue. In this issue the hostname localhost is specified, so it does not rely on wait-on assuming a default hostname. The wait-on issue jeffbski/wait-on#109 is unresolved, although there has been a fork https://github.com/metcoder95/wait-on created where the issue is resolved. The owner of the fork reports that he implemented "Happy Eyeballs" (see metcoder95/wait-on#20). I didn't understand your sentence "The latest versions of Node and some web servers listen on host 0.0.0.0 which no longer means localhost." and I am not sure if it is a correct explanation. What I saw in the react-scripts example is that the web server was listening on 0.0.0.0 (meaning all addresses), dns was resolving localhost to 127.0.0.1 and ::1 then wait-on tried to test the localhost IPv6 ::1 on Node.js 18 and the web server did not respond. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

bahmutov · 2023-02-26T18:01:29Z

Plus why would wait-on matter? We pass full URL to wait-on in this case. Sent from my iPhoneOn Feb 26, 2023, at 12:55, Gleb Bahmutov ***@***.***> wrote:Ok so the solution is to use explicit host and maybe put a warning when someone uses just a port Sent from my iPhoneOn Feb 26, 2023, at 12:45, Mike McCready ***@***.***> wrote: @bahmutov I tried this fix with #356 and it did not solve the issue. In this issue the hostname localhost is specified, so it does not rely on wait-on assuming a default hostname. The wait-on issue jeffbski/wait-on#109 is unresolved, although there has been a fork https://github.com/metcoder95/wait-on created where the issue is resolved. The owner of the fork reports that he implemented "Happy Eyeballs" (see metcoder95/wait-on#20). I didn't understand your sentence "The latest versions of Node and some web servers listen on host 0.0.0.0 which no longer means localhost." and I am not sure if it is a correct explanation. What I saw in the react-scripts example is that the web server was listening on 0.0.0.0 (meaning all addresses), dns was resolving localhost to 127.0.0.1 and ::1 then wait-on tried to test the localhost IPv6 ::1 on Node.js 18 and the web server did not respond. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

github-actions · 2023-02-26T19:15:30Z

🎉 This PR is included in version 1.15.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

haoqunjiang · 2023-02-27T07:09:22Z

Thanks for your work on this project!

But FYI I believe this release breaks the Cypress template of create-vue:
https://github.com/vuejs/create-vue/actions/runs/4277827772/jobs/7448606700#step:14:22

It looks like a breaking change to me.

I relied on the documented behavior that :4173 resolves to localhost:4173, and intentionally removed the host prefix after Vite changed its default from 127.0.0.1 to localhost. I expect this to continue working without a major release.

haoqunjiang · 2023-02-27T07:13:19Z

As for the Node.js 17+ and 0.0.0.0 issues, there's an explanation in the Vite documentation:
https://vitejs.dev/config/server-options.html#server-host

In Vite, we choose to default to localhost for the least surprise, and warn the users when their configuration might be problematic.

MikeMcC399 · 2023-02-27T08:06:45Z

Since this appears to be a breaking change, it would need to be reverted, as breaking changes require the release of a new major version.

MikeMcC399 · 2023-02-27T18:54:04Z

@bahmutov

How can I revert a release provides advice about what to do if a release accidently includes a breaking change.

Edit: It looks like 1.15.5 has been withdrawn from https://www.npmjs.com/package/start-server-and-test?activeTab=versions

bahmutov · 2023-02-27T19:07:54Z

I deprecated that npm dist tagSent from my iPhoneOn Feb 27, 2023, at 13:54, Mike McCready ***@***.***> wrote: @bahmutov How can I revert a release provides advice about what to do if a release accidently includes a breaking change. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

haoqunjiang · 2023-02-28T03:54:11Z

I deprecated that npm dist tag

1.x or ^1.0.0 still resolves to 1.5.5 according to https://semver.npmjs.com/

bahmutov · 2023-02-28T04:29:22Z

Please use the exact dependency versionSent from my iPhoneOn Feb 27, 2023, at 22:54, Haoqun Jiang ***@***.***> wrote: I deprecated that npm dist tag 1.x or ^1.0.0 still resolves to 1.5.5 according to https://semver.npmjs.com/ —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

A breaking change was introduced in start-server-and-test 1.5.5 and now :4173 is not equivalent to localhost:4173, which Vite uses by default, so we have to use the full url in the command. bahmutov/start-server-and-test#357 (comment)

MikeMcC399 · 2023-02-28T07:26:40Z

@sodatea

I deprecated that npm dist tag

1.x or ^1.0.0 still resolves to 1.5.5 according to https://semver.npmjs.com/

I don't think what you are seeing is contradictory. See https://docs.npmjs.com/deprecating-and-undeprecating-packages-or-package-versions. npm install disregards the deprecated version 1.5.5. I suspect if you let renovate run again it will not try to update to 1.5.5.

$ npm install [email protected]

changed 1 package, and audited 1605 packages in 3s

247 packages are looking for funding
  run `npm fund` for details

6 high severity vulnerabilities

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

$ npm ls start-server-and-test
[email protected] 
└── [email protected]

haoqunjiang · 2023-02-28T07:55:54Z

npm install disregards the deprecated version 1.5.5.

😮 I didn't know that. Nice feature!
Thank you for pointing this out to me!

A breaking change was introduced in start-server-and-test 1.5.5 and now :4173 is not equivalent to localhost:4173, which Vite uses by default, so we have to use the full url in the command. bahmutov/start-server-and-test#357 (comment)

bahmutov added 12 commits February 24, 2023 13:16

add 0.0.0.0 server ci example

32e6494

add explicit zero test

f94cee7

add timeout to the waiting failing demo

53fa0c2

add test and explanation

3f6e519

run more tests in Node v16

4393975

add debugging

7035940

update what we run on node v16

7d23f23

switch from localhost to 127.0.0.1 for default host

544c4fc

prepend localhost and common host names with http

14ea8cf

update readme

80acd62

ipv6 test

918aa1c

update localhost in README snippets

a7595a1

bahmutov changed the title ~~Test server with 0.0.0.0 host~~ Fix pinging the server when it listens on 0.0.0.0 and the user provided the port number Feb 24, 2023

bahmutov merged commit 9df0423 into master Feb 26, 2023

github-actions bot added the released label Feb 26, 2023

This was referenced Feb 27, 2023

start-server-and-test failure wait for localhost of react-app Node.js 18 (update) #358

Closed

chore(deps): update all non-major dependencies vuejs/create-vue#234

Merged

bahmutov mentioned this pull request Feb 27, 2023

feat: making the default host 127.0.0.1 #359

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix pinging the server when it listens on 0.0.0.0 and the user provided the port number #357

Fix pinging the server when it listens on 0.0.0.0 and the user provided the port number #357

bahmutov commented Feb 24, 2023 •

edited

Loading

bahmutov commented Feb 24, 2023

MikeMcC399 commented Feb 26, 2023

bahmutov commented Feb 26, 2023 via email

bahmutov commented Feb 26, 2023 via email

github-actions bot commented Feb 26, 2023

haoqunjiang commented Feb 27, 2023 •

edited

Loading

haoqunjiang commented Feb 27, 2023

MikeMcC399 commented Feb 27, 2023

MikeMcC399 commented Feb 27, 2023 •

edited

Loading

bahmutov commented Feb 27, 2023 via email

haoqunjiang commented Feb 28, 2023

bahmutov commented Feb 28, 2023 via email

MikeMcC399 commented Feb 28, 2023

haoqunjiang commented Feb 28, 2023

Fix pinging the server when it listens on 0.0.0.0 and the user provided the port number #357

Fix pinging the server when it listens on 0.0.0.0 and the user provided the port number #357

Conversation

bahmutov commented Feb 24, 2023 • edited Loading

bahmutov commented Feb 24, 2023

MikeMcC399 commented Feb 26, 2023

bahmutov commented Feb 26, 2023 via email

bahmutov commented Feb 26, 2023 via email

github-actions bot commented Feb 26, 2023

haoqunjiang commented Feb 27, 2023 • edited Loading

haoqunjiang commented Feb 27, 2023

MikeMcC399 commented Feb 27, 2023

MikeMcC399 commented Feb 27, 2023 • edited Loading

bahmutov commented Feb 27, 2023 via email

haoqunjiang commented Feb 28, 2023

bahmutov commented Feb 28, 2023 via email

MikeMcC399 commented Feb 28, 2023

haoqunjiang commented Feb 28, 2023

bahmutov commented Feb 24, 2023 •

edited

Loading

haoqunjiang commented Feb 27, 2023 •

edited

Loading

MikeMcC399 commented Feb 27, 2023 •

edited

Loading