modify webpack config to include angular2-template-loader #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geocine
changed the title
geocine
changed the title
|
Thanks @geocine! |
meDavid
reviewed
Jul 21, 2018
| @@ -8,12 +8,17 @@ const webpackOptions = { | |||
| rules: [ | |||
| { | |||
| test: /\.ts$/, | |||
| loaders: ['ts-loader', 'angular2-template-loader'], | |||
There was a problem hiding this comment.
I think this file is part of @bahmutov/add-typescript-to-cypress npm bundle and copied from there on install.
There was a problem hiding this comment.
You may close this, I created a PR at @bahmutov/add-typescript-to-cypress
|
I have set up Travis CI build for this project: https://travis-ci.org/bahmutov/cypress-angular-unit-test/builds |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as explained by @meDavid at #1 , the templates and styles are not resolved correctly, this PR resolves it
