Skip to content

Commit

Permalink
fix: use core 2 as prod dependency
Browse files Browse the repository at this point in the history
BREAKING CHANGE: requires experimental component testing
and Cypress v4.5.0+
  • Loading branch information
bahmutov committed May 12, 2020
1 parent a336963 commit 865cedc
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 7 deletions.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ describe('AppComponent', () => {

- [examples/ng7](examples/ng7)

### External

- [Tour of Heroes](https://github.com/bahmutov/ng9-tour-of-heroes)

## Working

I have successfully used this mounting approach to test components in other frameworks.
Expand Down
3 changes: 1 addition & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@
"main": "dist",
"types": "dist",
"homepage": "https://github.com/bahmutov/cypress-angular-unit-test#readme",
"dependencies": {},
"dependencies": {
"core-js": "2.6.9"
},
"devDependencies": {
"core-js": "2.6.9",
"@angular/common": "7.2.16",
"@angular/core": "7.2.16",
"@angular/compiler": "7.2.16",
Expand All @@ -34,7 +35,6 @@
"@angular/compiler": "*",
"@angular/platform-browser": "*",
"@angular/platform-browser-dynamic": "*",
"core-js": "*",
"zone.js": "*"
},
"repository": {
Expand Down
4 changes: 2 additions & 2 deletions support.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
// TODO what do we need from here as peer or production dependencies?
require('core-js/es6/reflect')
require('core-js/es7/reflect')
require('zone.js/dist/zone')

// require('zone.js/dist/zone')

beforeEach(() => {
debugger
const html = `
<head>
<meta charset="UTF-8">
Expand Down

0 comments on commit 865cedc

Please sign in to comment.