-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a new macro parameter ho, in order to reuse existing ho. #45
Conversation
so we can save ho progress periodically. or resume ho.
Cool thanks for taking a stab at this! |
I have added some test cases. |
for it might contain variables captured from outside. if these variables have changed, then the old ho will be invalid. so should only resume sampler and history.
Cool! Are you happy with the PR and it's ready to be merged? |
Yes. I have used it for a whole day. seems OK. |
Awesome, thanks! |
It seems this might actually have broken the parallel The tests had by mistake not tested parallel execution since |
I'm sorry for that. I just know Pkg test has a parameter "--coverage" last week. |
No worries, the tests certainly appeared to cover also the parallel case. The problem is solved by now. If you want to produce coverage files locally, I believe you can have coverage results printed to file with the second option below
There are also some tools for this available at https://github.com/JuliaCI/Coverage.jl |
so we can save ho progress periodically. or resume ho.
fixes #23