Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plots.jl should not be a dependence #57

Closed
okartal opened this issue Sep 18, 2023 · 4 comments · Fixed by #60
Closed

Plots.jl should not be a dependence #57

okartal opened this issue Sep 18, 2023 · 4 comments · Fixed by #60

Comments

@okartal
Copy link

okartal commented Sep 18, 2023

When using DynamicAxisWarping, it introduces dependencies on Plots.jl
@shayandavoodii
Copy link

Because it introduces dtwplot and other plotting functions. I do not know why this issue is still open while the maintainer is online these days.

@baggepinnen
Copy link
Owner

I do not know why this issue is still open while the maintainer is online these days.

Feel free to submit a PR that fixes the issue if you find it urgent. I have other engagements that are currently taking priority.

@shayandavoodii
Copy link

shayandavoodii commented Oct 17, 2023 •
edited
Loading

@baggepinnen, You did not get my point. I was answering @okartal , explaining why you've used Plots in the dependencies! Anyway, good luck with your engagements!

@baggepinnen
Copy link
Owner

baggepinnen commented Oct 17, 2023 •
edited
Loading

Thanks ;) OP is likely correct in that RecipesBase could be used instead of Plots though

baggepinnen added a commit that referenced this issue Oct 18, 2023
@baggepinnen
remove Plots.jl from dependencies
c138455 
Plots.jl now has to be loaded manually to access plots, which was already the documented workflow

Closes #57
@baggepinnen baggepinnen mentioned this issue Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove Plots.jl from dependencies baggepinnen/DynamicAxisWarping.jl
3 participants
@okartal @baggepinnen @shayandavoodii