Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for embedded license file #76

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FroggieFrog
Copy link

@FroggieFrog FroggieFrog commented Feb 16, 2024

This PR adds support for downloading an embedded license file and is based on this PR by @rbdavison.

current situation

If a package has an embedded license file, the link on the package details page is https://aka.ms/deprecateLicenseUrl which states:

Some NuGet clients and NuGet feeds might not be able to surface licensing information.
To maintain backward compatibility in such cases, the license URL points to this document about how to retrieve the license information.

So a user has to do multiple manual steps to download the license.

situation after this PR

The package details page has a direct link to the license.
So a user has to do one click to download the license.

Todo:

  • add Migrations for new features
  • add support to the various providers
  • maybe add some more unit tests
  • maybe add some integration tests

more information:

Testdata I used/created: testdata.zip

@Regenhardt
Copy link

Since we need a migration anyway, can you add a "Deprecated" boolean to the package as well? We can add it to the rest of the application later, but it requires a migration too and I feel like it's always nice to keep those to a minimum. It was requested in loic-sharma#723.

@Regenhardt
Copy link

We could keep the commits separate instead of squashing on merge too if anyone thinks this might overload the feature, that might keep the history clearer.

@FroggieFrog
Copy link
Author

I would vote for separate PRs because those are separate features.

@rbdavison
Copy link

Don't like to jump in on your project. I'm glad you liked my code and want to pull in some of the changes.
I also did Migrations in the source PR. Why not include those changes as well?

Copy link

This PR is stale because it has been open for 90 days with no activity. Remove the stale label, comment, or this will be closed in 10 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants