-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow record/map to transform type with optional properties #60
Conversation
Any chance this PR could have a review? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pending 1 non-blocking discussion/nitpick.
…han/fun into record_omit_immutable_props
Thanks for the review. Switched to fenced ts block for now. Feel free to let me know if you want some hands to port existing examples to any chosen style. |
This looks good, just needs another deno fmt and I'll merge it right in. |
* refactor!: curried record/omit with immutable keys * fix(record/map): allow optional properties * fix(fmt): re-format using latest version of deno * fix: fenced ts block instead of @example tag Co-authored-by: Brandon Blaylock <[email protected]> FossilOrigin-Name: 939d8c2cde7a8c9138b3770a2c3fea2bb76488d9c5fd287f1d7612e18bf724e4
The current implementation of
record/map
refuses to map a type with optional properties:Because:
This PR allows such usage.