Add [Discord] badge #977
Merged
Add [Discord] badge #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
service-tests/discord.js
Outdated
|
|
||
| t.create('invalid server ID') | ||
| .get('/12345.json') | ||
| .expectJSON({ name: 'chat', value: 'inaccessible' }); |
There was a problem hiding this comment.
Is there a way to distinguish "room not found" from other types of errors? That could be a more helpful error message.
There was a problem hiding this comment.
Oh, good idea. Their server returns a 404 error for invalid rooms, so I could display "invalid" rather than "inaccessible".
There was a problem hiding this comment.
Okay, I revised the pull request to handle this case separately. Let me know if it looks good :D
paulmelnikow
approved these changes
Apr 30, 2017
- Add test case for 500 errors
paulmelnikow
approved these changes
May 1, 2017
|
Hi @Daniel15! As a follow-up, could you add instructions to get the server ID in a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a badge for Discord, along with a test.
For reference, their official badge looks like this:
