Split various utilities into standalone files

[Daniel15]

The following utilities have been split into other files:

• php-version.js
  • phpStableVersion (renamed to "isStable")
  • phpLatestVersion (renamed to "latest")
  • phpVersionCompare (renamed to "compare")
  • phpNumberedVersionData (renamed to "numberedVersionData")
  • Only used within PHP version comparison code:
    • omitv
    • asciiVersionCompare
• version.js
  • latestVersion (renamed to "latest")
  • listCompare
  • latestDottedVersion
  • compareDottedVersions
• color-formatters.js:
  • versionColor (renamed to "version")
  • floorCountColor (renamed to "floorCount")
  • downloadCountColor (renamed to "downloadCount")
  • coveragePercentageColor (renamed to "coveragePercentage")
• text-formatters.js
  • starRating
  • currencyFromCode
  • ordinalNumber
  • metric

To avoid changing any of the code in server.js that uses these methods, I'm aliasing them when importing:

const {
  compare: phpVersionCompare,
  latest: phpLatestVersion,
  isStable: phpStableVersion,
} = require('./lib/php-version.js');

(this syntax is object destructuring, added in Node.js 6.0.0)

This allows all code using phpVersionCompare() to continue to work with no changes and will avoid merge conflicts in the open pull requests.

Ideally I would have done something like this:

const phpVersion = require('./lib/php-version.js');

and then changed phpVersionCompare() to phpVersion.compare(), to keep everything namespaced(-ish).

I confirmed that these changes worked on Node.js 6.4.0 by running the server and then loading try.html.

There's a few badges that are broken that aren't due to this pull requests - For example the example badge for "Scrutinizer branch" shows "NaN%" 😛

References #948
cc @paulmelnikow

[paulmelnikow]

Looks good!

[paulmelnikow]

You can omit the .js suffix in these requires. There are a few in server.js too.

[paulmelnikow]

As you wrote, this seems like a good way to handle this, for the moment, to avoid conflicts. It'll be easy to change these names later.

[paulmelnikow]

Did you make any changes in these implementations?

[paulmelnikow]

Thanks for the great explanation and the changes.

Will leave this open a couple days in case @espadrine wants to comment.

I'll be AFK this weekend BTW. ⛰ 🛶 🏕

[Daniel15]

Oh, I should have mentioned that I did not make any changes to the implementations, they were simply cut and pasted. I wish Github showed that lines of codes were moved or copied verbatim, like Phabricator dies. I used the .js suffix for consistency, because the other requires are using it. Sent from my phone. On Apr 20, 2017 6:24 AM, "Paul Melnikow" <[email protected]> wrote: Thanks for the great explanation and the changes. Will leave this open a couple days in case @espadrine <https://github.com/espadrine> wants to comment. I'll be AFK this weekend BTW. ⛰ 🛶 🏕 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#952 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFnHaIVpB8BXmx4Stzcwd0smnpN5q-nks5rx1yDgaJpZM4NCjeA> .

[paulmelnikow]

I used the .js suffix for consistency, because the other requires are using it.

Hehe, didn't realize that. When I see one, I wonder if something strange is going on with those files. We may as well stop, don't you think?