Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show example format for the dynamic badge that is selected in the frontend #8505

Closed
wants to merge 1 commit into from

Conversation

MonliH
Copy link
Contributor

@MonliH MonliH commented Oct 8, 2022

This PR implements the suggestion in #1844. That is, it shows the example format for the current selected data type:
image

When no datatype is selected, this implementation shows a more general form, https://img.shields.io/badge/dynamic/<DATA_TYPE>?url=<DATA_URL>&label=<LABEL>&query=<QUERY>&color=<COLOR>&prefix=<PREFIX>&suffix=<SUFFIX>

@calebcartwright
Copy link
Member

Really appreciate the PR, but I'm probably a 👎 on this one for a few reasons.

First, we've consistently gotten reports from users that the existing UI is unclear/doesn't necessarily convey relevant features. I can understand where someone deeply familiar with using the dynamic badge builder in that section of the page would view the other examples as visual noise, but I think having it present (with zero user action) for new users is more important than reducing that visual noise.

Secondly, we're in need/planning on overhauling the frontend entirely, and I don't think it's worth making any minor changes which aren't objectively, non-controversial improvements to the existing ui (refs #1899 and #7815).

I move we close this, but will wait to hear what @chris48s thinks

@MonliH
Copy link
Contributor Author

MonliH commented Nov 5, 2022

Ah I understand. That's actually what I thought after investigating the redesign efforts (very exciting stuff!). Fair enough to not want to make minor changes like this when most of the UI will be overhauled anyway.

@calebcartwright
Copy link
Member

Thanks again @MonliH but going to go ahead and close given the above discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants