Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up cache module; affects [feedz jenkinsplugin myget node nuget packagist travis wordpress] #7319

Merged
merged 4 commits into from
Nov 29, 2021

Conversation

chris48s
Copy link
Member

Closes #4655
Refs #7215 (comment)

This PR finishes up the last bit of tangential follow up from the refactoring work done under #4655

I opted not to bother taking on another cache dependency for this. I've tidied things up a bit, made the terminology a bit more normal and added some tests but I've pretty much left the implementation alone.

- "regular update" to "cached resource"
- "interval" to "ttl"
- move file and update imports
@chris48s chris48s added the core Server, BaseService, GitHub auth, Shared helpers label Nov 28, 2021
@shields-ci
Copy link

Warnings
⚠️ This PR modified service code for jenkins but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified the server but none of its tests.
That's okay so long as it's refactoring existing code.
Messages
📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 8ef5f8a

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chris48s chris48s merged commit feb1682 into badges:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Server, BaseService, GitHub auth, Shared helpers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate away from request
3 participants