use downloads renderer in next batch of classes, run [hexpm homebrewdownloads jenkinsplugininstalls jetbrainsdownloads jsdelivr modrinth]] #7210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
commented
Oct 29, 2021
| @@ -27,6 +29,7 @@ function renderDownloadsBadge({ | |||
| labelOverride, | |||
| colorOverride, | |||
| messageSuffixOverride, | |||
| versionedLabelPrefix = 'downloads', | |||
There was a problem hiding this comment.
Added to support use cases where classes want to support tag/version specific download counts but are using a label other than downloads
|
calebcartwright
commented
Oct 29, 2021
Comment on lines
-26
to
-40
| static _getSchema(version) { | ||
| if (version) { | ||
| return schemaInstallationsPerVersion | ||
| } else { | ||
| return schemaInstallations | ||
| } | ||
| } | ||
|
|
||
| static _getLabel(version) { | ||
| if (version) { | ||
| return `installs@${version}` | ||
| } else { | ||
| return 'installs' | ||
| } | ||
| } |
There was a problem hiding this comment.
Trying to keep the diff focused on the refactoring to utilize the new render helper, but felt inclined to update this one with our more canonical fetch/transform/render separation of concerns and applied some broader refactoring to that end
chris48s
approved these changes
Oct 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation from #7163