Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align style prop of coalesceBadge() with internal makeBadge() #5726

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Align style prop of coalesceBadge() with internal makeBadge() #5726

merged 3 commits into from
Oct 20, 2020

Conversation

paulmelnikow
Copy link
Member

This is an analogous change to #5719 for ’template’ and ’style’. (See the top comment for more explanation.)

The diff is simpler since there are fewer test changes in this one.

@paulmelnikow
Align style prop of coalesceBadge() with internal makeBadge()
af8b386 
This is an analogous change to #5719 for `’template’` and `’style’`. (See the top comment for more explanation.)

The diff is simpler since there are fewer test changes in this one.
@paulmelnikow paulmelnikow added core Server, BaseService, GitHub auth, Shared helpers npm-package Badge generation and badge templates labels Oct 16, 2020
@shields-cd shields-cd temporarily deployed to shields-staging-pr-5726 October 16, 2020 23:28 Inactive
@shields-ci
Copy link

shields-ci commented Oct 16, 2020 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against e0cdc64

calebcartwright
calebcartwright approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with the change, though are we going to need a new major version bump of the package to accompany? I wasn't quite sure how to take the inline comments quoted "public"..

@paulmelnikow
Copy link
Member Author

No, unless I've made a mistake here, this is only affecting private/internal APIs.

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-5726 October 18, 2020 22:03 Inactive
@paulmelnikow paulmelnikow merged commit f1a5dd9 into master Oct 20, 2020
@paulmelnikow paulmelnikow deleted the template-style branch October 20, 2020 23:16
@github-actions
Copy link
Contributor

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
core Server, BaseService, GitHub auth, Shared helpers npm-package Badge generation and badge templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulmelnikow @shields-ci @calebcartwright @shields-cd