Support NodeJS 4.x - Upgrade Canvas

[ekristen]

Updating Canvas to 1.3.0 allows this to build under NodeJS 4.x

[espadrine]

Good good good! Thanks a lot.

It doesn't work with node 5, though, I think. I get Module version mismatch. Expected 47, got 14. Maybe we can skip 4 and use 5?

[ekristen]

4 is LTS. Probably need to rm rf your node_modules folder and reinstall all modules, that should fix the module error you saw.

Sent from my iPhone

On Nov 4, 2015, at 02:53, Thaddee Tyl [email protected] wrote:

Good good good! Thanks a lot.

It doesn't work with node 5, though, I think. I get Module version mismatch. Expected 47, got 14. Maybe we can skip 4 and use 5?

—
Reply to this email directly or view it on GitHub.

[espadrine]

There is a significant change to the way canvases compute size; do you know if font loading changed?

Edit: looks like I studied it a bit a while ago: #458.

TL;DR: this commit broke node-canvas Automattic/node-canvas@7522aca, and this patch Automattic/node-canvas#543 fixes it, but nobody reviewed it, and one of the maintainers suggests this patch Automattic/node-canvas#628 which simply reverts the issue.

One option is to switch to pdfkit: #496, which looks more and more like the way out.

[LinusU]

Module version mismatch. Expected 47, got 14

This error is because the module that is being loaded was compiled for an older version of Node.js than is running. It can be fixed with npm rebuild.

Automattic/node-canvas#543 fixes it, but nobody reviewed it

I'm sorry that this haven't been properly reviewed yet. I posted a comment there and I'll be happy to test it once it's been rebased on master.

Re. the path, I would recommend using ^1.3.0 instead of ~1.3.0. That way you'll receive all backwards-compatible releases, and not just bugfix releases. This goes for all of your dependencies.

I'll be happy to help you get this working with the latest version of canvas 👍

[yannickglt]

+1

[yannickglt]

@ekristen The build of the docker image fails with the version 1.3.0 of the lib canvas. You may need to update the Dockerfile as it is based on the image node:0.12.7.

[ekristen]

I'll take a look.

[paulmelnikow]

Made obsolete by #496, which switched from canvas to pdfkit.