Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move [Twitter] url to query param #4027

Merged
merged 6 commits into from
Sep 16, 2019
Merged

move [Twitter] url to query param #4027

merged 6 commits into from
Sep 16, 2019

Conversation

calebcartwright
Copy link
Member

Refs #3714

@calebcartwright calebcartwright added the service-badge New or updated service badge label Sep 15, 2019
@shields-cd shields-cd temporarily deployed to shields-staging-pr-4027 September 15, 2019 23:06 Inactive
@shields-ci
Copy link

shields-ci commented Sep 15, 2019 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @calebcartwright!

Generated by 🚫 dangerJS against be0b3b6

paulmelnikow
paulmelnikow reviewed Sep 16, 2019
View reviewed changes
Copy link
Member

@paulmelnikow paulmelnikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the badge suggestion endpoint too?

@calebcartwright
Copy link
Member Author

Could you update the badge suggestion endpoint too?

Good catch!

@shields-cd shields-cd temporarily deployed to shields-staging-pr-4027 September 16, 2019 01:24 Inactive
@shields-cd shields-cd temporarily deployed to shields-staging-pr-4027 September 16, 2019 01:27 Inactive
paulmelnikow
paulmelnikow previously approved these changes Sep 16, 2019
View reviewed changes
@shields-cd shields-cd temporarily deployed to shields-staging-pr-4027 September 16, 2019 01:31 Inactive
@repo-ranger repo-ranger bot merged commit db0ebf1 into master Sep 16, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@calebcartwright calebcartwright deleted the twitter-url-query-param branch September 16, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmelnikow paulmelnikow paulmelnikow approved these changes

Assignees
No one assigned
Labels
service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calebcartwright @shields-ci @paulmelnikow @shields-cd