Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor [vaadindirectory] badges #3339

Merged
merged 4 commits into from
Apr 21, 2019
Merged

refactor [vaadindirectory] badges #3339

merged 4 commits into from
Apr 21, 2019

Conversation

chris48s
Copy link
Member

Side note: Not sure if #3243 is totally fixed, but all the tests have passed consistently while I've been working on these badges this evening

@chris48s chris48s added the service-badge New or updated service badge label Apr 20, 2019
@shields-ci
Copy link

shields-ci commented Apr 20, 2019 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 8133316

@calebcartwright
Copy link
Member

I'm still a little confused by when/if GH reflects the staging app deployments (currently shows as not deployed), but the apps is here https://shields-staging-pr-3339.herokuapp.com/

calebcartwright
calebcartwright previously approved these changes Apr 21, 2019
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added a couple non-blocking comments/questions inline. Happy to re-review/approve if you decide to make any other changes

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-3339 April 21, 2019 17:48 Inactive
@chris48s
Copy link
Member Author

cheers for reviewing

@chris48s chris48s merged commit 05af1f8 into badges:master Apr 21, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
service-badge New or updated service badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chris48s @shields-ci @calebcartwright @paulmelnikow