Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Branches to Codeship and support for codacy #310

Closed
wants to merge 3 commits into from

Conversation

@nicolindemann nicolindemann changed the title Fix #309 Add Branches to Codeship Nov 21, 2014
@espadrine
Copy link
Member

Thanks a lot!

Can you rebase out the PR and readme commits please? (Use git rebase -i HEAD^^^^^^^ and delete the corresponding commits.)

@nicolindemann
Copy link
Contributor Author

Done

@nicolindemann
Copy link
Contributor Author

My git messed something up. Now 2 issues are located in this PR.. is this ok?

maybe its too late ...

@nicolindemann nicolindemann changed the title Add Branches to Codeship Add Branches to Codeship and support for codacy Nov 22, 2014
@espadrine
Copy link
Member

That's even better!

There was an extra console.log() left, which I removed.

More importantly, I tend to add a comment describing example parameters to use for each badge. Can I safely use /codacy/e27821fb6289410b8f58338c7e0bc686.svg here for at least six months?

Additionally, I tend to be scared of scraping because of how brittle it often ends up being. Is there an effort somewhere from Codacy to build a public API which offers the same level of information?

espadrine added a commit that referenced this pull request Nov 23, 2014
@espadrine
Copy link
Member

Committed, see bfbe3ca and 238b40d

Thanks a lot!

@espadrine espadrine closed this Nov 23, 2014
@nicolindemann
Copy link
Contributor Author

Sure! You can also use the Badge for the webpage. It represents my fork of shields on codacy. (Public Dashboard btw: https://www.codacy.com/public/nicolindemann_2649/shields/dashboard )

A public API is currently not provided by codacy, as far as i know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants