Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for wordpress plugin version, total downloads, rating and supported wordpress version. #300

Closed
wants to merge 7 commits into from

Conversation

anderly
Copy link
Contributor

@anderly anderly commented Nov 3, 2014

Pull request to close #299

@anderly anderly changed the title Added support for wordpress plugin version, total downloads and rating. Added support for wordpress plugin version, total downloads, rating and supported wordpress version. Nov 4, 2014
// wordpress plugin version integration.
camp.route(/^\/wordpress\/plugin\/v\/(.*)\.(svg|png|gif|jpg|json)$/,
cache(function(data, match, sendBadge, request) {
var plugin = match[1]; // eg, `localeval`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give a functional example in the comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: see commit d3f8cdb

@espadrine
Copy link
Member

Thanks a lot for this! It looks pretty straightforward. I'd like you to add valid plugin names that you want to be featured, and I'll add them to the website as examples.

@anderly
Copy link
Contributor Author

anderly commented Nov 4, 2014

Here are two examples for each badge using Automattic's Akismet and Jetpack plugins.

You can also see what these will eventually look like on one of my plugin's readme: https://github.com/anderly/woocommerce-mailchimp/blob/master/README.md

WordPress Plugin Version Example:
https://img.shields.io/wordpress/plugin/v/akismet.svg
https://img.shields.io/wordpress/plugin/v/jetpack.svg

WordPress Plugin Downloads Example:
https://img.shields.io/wordpress/plugin/dt/akismet.svg
https://img.shields.io/wordpress/plugin/dt/jetpack.svg

WordPress Plugin Ratings Example:
https://img.shields.io/wordpress/plugin/r/akismet.svg
https://img.shields.io/wordpress/plugin/r/jetpack.svg

WordPress Plugin WordPress Core Compatibility Example:
https://img.shields.io/wordpress/v/akismet.svg
https://img.shields.io/wordpress/v/jetpack.svg

Added ‘ total’ to end of /wordpress/plugin/dt/ badgeText
Added ‘ tested’ to end of /wordpress/v/ badgeText to better reflect
meaning.
@anderly
Copy link
Contributor Author

anderly commented Nov 5, 2014

Need anything else from me to close this? Let me know.

@espadrine
Copy link
Member

Thanks a lot for all this information! Your PR is really stellar, which makes me feel bad for taking this long.

I merged it and put it live. However, I have a question still. What is WordPress Core Compatibility Example? My light googling failed me.

@espadrine
Copy link
Member

(Note: see commits 92e1079 and later, since they were rebased. Authorship was obviously kept.)

@anderly
Copy link
Contributor Author

anderly commented Nov 7, 2014

Basically, it tells whether the plugin author has tested their plugin with the current version of WordPress or at least one of the current versions supported.

Here's an example of one that is out of date: http://wordpress.org/plugins/debug-bar-console

You'll notice on that page it says "Compatible up to 3.4.2".

@anderly
Copy link
Contributor Author

anderly commented Nov 7, 2014

And here's one that has been tested with the current version of WordPress http://wordpress.org/plugins/debug-bar

@anderly
Copy link
Contributor Author

anderly commented Nov 7, 2014

Here's the associated badges for those two examples which hopefully makes more sense:

http://img.shields.io/wordpress/v/debug-bar-console.svg
http://img.shields.io/wordpress/v/debug-bar.svg

@espadrine
Copy link
Member

Thanks a lot! That's indeed pretty useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for WordPress plugins
2 participants