-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for wordpress plugin version, total downloads, rating and supported wordpress version. #300
Conversation
Added support for wordpress version compatibility.
// wordpress plugin version integration. | ||
camp.route(/^\/wordpress\/plugin\/v\/(.*)\.(svg|png|gif|jpg|json)$/, | ||
cache(function(data, match, sendBadge, request) { | ||
var plugin = match[1]; // eg, `localeval`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give a functional example in the comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: see commit d3f8cdb
Thanks a lot for this! It looks pretty straightforward. I'd like you to add valid plugin names that you want to be featured, and I'll add them to the website as examples. |
Here are two examples for each badge using Automattic's Akismet and Jetpack plugins. You can also see what these will eventually look like on one of my plugin's readme: https://github.com/anderly/woocommerce-mailchimp/blob/master/README.md WordPress Plugin Version Example: WordPress Plugin Downloads Example: WordPress Plugin Ratings Example: WordPress Plugin WordPress Core Compatibility Example: |
Added ‘ total’ to end of /wordpress/plugin/dt/ badgeText Added ‘ tested’ to end of /wordpress/v/ badgeText to better reflect meaning.
Need anything else from me to close this? Let me know. |
Thanks a lot for all this information! Your PR is really stellar, which makes me feel bad for taking this long. I merged it and put it live. However, I have a question still. What is WordPress Core Compatibility Example? My light googling failed me. |
(Note: see commits 92e1079 and later, since they were rebased. Authorship was obviously kept.) |
Basically, it tells whether the plugin author has tested their plugin with the current version of WordPress or at least one of the current versions supported. Here's an example of one that is out of date: http://wordpress.org/plugins/debug-bar-console You'll notice on that page it says "Compatible up to 3.4.2". |
And here's one that has been tested with the current version of WordPress http://wordpress.org/plugins/debug-bar |
Here's the associated badges for those two examples which hopefully makes more sense: http://img.shields.io/wordpress/v/debug-bar-console.svg |
Thanks a lot! That's indeed pretty useful! |
Pull request to close #299