Add the ability to output badges as JSON. #283
Conversation
Timeouts are caused by the launch of Google Chrome taking time. (Since it only launches once on the server upon startup, it isn't an issue |
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "name": "{{=it.text[0]}}", | |||
| "value": "{{=it.text[1]}}" | |||
There was a problem hiding this comment.
I could be wrong (in which case tell me why), but I think this could cause breaking bugs.
Wouldn't JSON.stringify(it.text[0]) be a lot better? (Obviously, you'd need to remove the surrounding ".)
|
I'm really eager to see this merged! |
|
All very good points, I'm away for the weekend, but I'll update this early next week and hopefully we can get live! Good point on the breaking change, didn't really think about that. Wasn't sure how it was being used outside of your website. thanks for reviewing and stay tuned. |
|
Okay, I've refactored as discussed. I actually brought this branch current with the latest commit (7212d71). There should now be no backwards breaking changes, and the tests are all passing. Let me know if I've missed anything! |
| @@ -200,7 +200,7 @@ function cache(f) { | |||
| } | |||
| var badgeData = getBadgeData('vendor', data); | |||
| badgeData.text[1] = 'unresponsive'; | |||
| badge(badgeData, makeSend('svg', ask.res, end)); | |||
| badge(badgeData, makeSend(match[0].split('.').pop(), ask.res, end)); | |||
There was a problem hiding this comment.
I should note that I wasn't able to test this particular line of code, since I wasn't sure how to trigger an "unresponsive" request.
|
This is amazing. It truly is. Thanks a lot for the great work you did. I won't put it live today; I'll play with it some more to verify possible issues. One thing that pops up first is that the |
|
Thanks, very happy to contribute to an awesome project. ;) Good call on not assuming that |
As discussed in issue #264, here is update to allow outputting badges as JSON. This took a little bit of "hackwork", since the entire system is designed to output images, not plain text. Nonetheless, it seems to work very well. Simply use
.jsona the file extension, and the data is returned as JSON. I've also added the CORS header right away as well.Note, the "any badge" feature will not work with JSON, as that makes no sense.