Add readme badges to gamify refactoring some more #2562
Conversation
|
| <img src="https://img.shields.io/github/search/badges/shields/extends%20LegacyService.svg?label=legacy%20services%20needing%20refactor" | ||
| alt="legacy services needing refactor"></a> | ||
| <a href="https://github.com/search?utf8=%E2%9C%93&q=exampleUrl+repo%3Abadges%2Fshields+path%3A%2Fservices&type=Code&ref=advsearch&l=&l="> | ||
| <img src="https://img.shields.io/github/search/badges/shields/exampleUrl.svg?label=`exampleUrl`s%20needing%20refactor" |
There was a problem hiding this comment.
Could be cache (or user error) but I'm seeing 49 code results in GH search, while the badge is displaying 51. Maybe the 51 is coming from the code results (49) + commits (2)?
There was a problem hiding this comment.
Yea, that sounds right. I wonder if the badge supports a more complex query.
There was a problem hiding this comment.
It looks like the badge implementation supports anything that can be added directly to the query param, for example:
However, it looks like type is a separate query param (&type=Code) which we'd need to to exclude commits. That sounds like a potential new feature/enhancement to the GH search badge, but def. out of scope for this PR IMO.
Ref #1358 (comment)