Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Danger server guideline #2467

Merged
merged 3 commits into from
Dec 6, 2018
Merged

Updated Danger server guideline #2467

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcb85c7
Updated Danger server guideline
PyvesB Dec 6, 2018
c4b2a82
Removed unused variable
PyvesB Dec 6, 2018
b87b19b
Merge branch 'master' into dangerserver
PyvesB Dec 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions dangerfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
//
// To test changes to this file, pick a PR to test against, then run
// `./node_modules/.bin/danger pr pr-url`
// Note that the line numbers in the runtime errors are incorrecr.
// Note that the line numbers in the runtime errors are incorrect.

const { danger, fail, message, warn } = require('danger')
const chainsmoker = require('chainsmoker')
Expand All @@ -24,7 +24,7 @@ const documentation = fileMatch(
'frontend/components/usage.js'
)
const server = fileMatch('server.js')
const serviceTests = fileMatch('services/**/*.tester.js')
const serverTests = fileMatch('server.spec.js')
const helpers = fileMatch(
'lib/**/*.js',
'!**/*.spec.js',
Expand Down Expand Up @@ -66,13 +66,11 @@ if (packageJson.modified && !packageLock.modified) {
warn(`${message} - <i>${idea}</i>`)
}

if (server.modified && !serviceTests.createdOrModified) {
if (server.modified && !serverTests.modified) {
warn(
[
'This PR modified the server but none of the service tests. <br>',
"That's okay so long as it's refactoring existing code. ",
'Otherwise, please consider adding tests to the service: ',
'[How-to](https://github.com/badges/shields/blob/master/doc/service-tests.md#readme)',
'This PR modified the server but none of its tests. <br>',
"That's okay so long as it's refactoring existing code.",
].join('')
)
}
Expand Down