Modernize some more examples #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le requires readthedocs]
paulmelnikow
changed the title
Generated by 🚫 dangerJS |
chris48s
approved these changes
Dec 4, 2018
RedSparr0w
reviewed
Dec 4, 2018
| @@ -179,11 +179,9 @@ class SteamCollectionSize extends BaseSteamAPI { | |||
| return [ | |||
| { | |||
| title: 'Steam Collection Files', | |||
| exampleUrl: '180077636', | |||
| pattern: ':id', | |||
There was a problem hiding this comment.
I'm assuming we don't require a pattern if there is only 1 parameter,
Do you think it could still be worth keeping it though?
Edit: Never mind, I see above that its already defined
There was a problem hiding this comment.
Ah, it's that by default, an example inherits its pattern from the route. Since I've brought the names into alignment, it doesn't need to be specified again.
There was a problem hiding this comment.
Ah yeah just saw that 😆
Thanks 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1961
No base URLs or server code was changed here, so we don't need to run service tests.