Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example: Canonicalize urlPattern to pattern #2341

Merged
merged 2 commits into from
Nov 18, 2018
Merged

Example: Canonicalize urlPattern to pattern #2341

merged 2 commits into from
Nov 18, 2018

Conversation

paulmelnikow
Copy link
Member

Close #2334

To avoid merge conflicts, I've deferred removing the aliasing logic in prepareExamples. That whole function will be refactored momentarily, and there's also #2339 open.

@paulmelnikow paulmelnikow added the service-badge New or updated service badge label Nov 17, 2018
@shields-ci
Copy link

Warnings
⚠️ This PR modified service code for ansible but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for dockbit but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for docker but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for eclipse-marketplace but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for discord but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for gem but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for github but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for gitter but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for hexpm but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for itunes but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for depfu but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for jenkins but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for ctan but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for jetbrains but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for codecov but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for librariesio but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for codeclimate but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for npm but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for codacy but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for pypi but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for clojars but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for readthedocs but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for circleci but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for requires but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for cdnjs but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for shippable but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for bitrise but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for steam but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for bitbucket but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for swagger but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for azure-devops but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for travis but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for aur but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for uptimerobot but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for appveyor but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for wercker but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for apm but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for wordpress but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for f-droid but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS

Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. There may be a few other lingering open PRs where we need to make this update too

@paulmelnikow paulmelnikow merged commit 3ad742e into master Nov 18, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants