Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uri -> url in the front end + examples #2006

Merged
merged 2 commits into from
Aug 29, 2018
Merged

Update uri -> url in the front end + examples #2006

merged 2 commits into from
Aug 29, 2018

Conversation

paulmelnikow
Copy link
Member

This continues a consistency update we’ve been making to standardize on URL. This also helps with copying and pasting between all-badge-examples and new-style services, where it’s otherwise easy to make a mistake.

This continues a consistency update we’ve been making to standardize on URL. This also helps with copying and pasting between all-badge-examples and new-style services, where it’s otherwise easy to make a mistake.
@shields-ci
Copy link

Messages
📖

✨ Thanks for your contribution to Shields, @paulmelnikow!

📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS

Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, a URL is more specific than a URI and better reflects what the strings we're passing around actually are.

@paulmelnikow
Copy link
Member Author

Thanks for reviewing. Yea. There's also this recommendation from the WHATWG to standardize on "URL": https://url.spec.whatwg.org/#goals

Ref: #1322 #1341

@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the uri-to-url-frontend branch August 29, 2018 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants