Increased default BADGE_MAX_AGE_SECONDS #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyvesB
added
the
performance-improvement
Generated by 🚫 dangerJS |
|
Under the circumstances, I'm fine with this. 😝 Should we add a note to the website where we talk about |
paulmelnikow
approved these changes
Aug 4, 2018
|
@paulmelnikow I have included the current default inside the |
RedSparr0w
approved these changes
Aug 6, 2018
This was referenced Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to discussions in #1806. Until that pull request is merged and we have an easy way of configuring the environment variables on the server, we should have a non-0 value in the meantime.
@paulmelnikow suggested 60 seconds whereas @Nyholm was advocating larger values (300, 600), so I've opted for something intermediary, 120 seconds. We can easily change it if need-be and revert it once the other PR is merged.