Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TeamCity code coverage #178

Merged
merged 0 commits into from
May 26, 2014
Merged

Conversation

Daniel15
Copy link
Member

Added support for retrieving code coverage from Codebetter TeamCity.

@espadrine
Copy link
Member

This is a pretty good pull request! Thanks again!

There is a small typo. If you wish to fix it, I'd be most grateful. The name of the new function you built is coveragePercentageColor, but you called it as coveragePercentageColour on line 627.

@Daniel15
Copy link
Member Author

Sorry about that! I originally called it coveragePercentageColour but renamed it to coveragePercentageColor just before sending the pull request. I guess I missed one of the calls.

@Daniel15
Copy link
Member Author

Ugh I edited the file via the Github interface and it looks like it totally messed it up and for some reason the whole file is marked as changed. THANKS GITHUB <_<
I'll get it fixed.

@Daniel15
Copy link
Member Author

@espadrine - This should be fine to merge now - Did you have any other changes you'd like me to do? Thanks!

@espadrine
Copy link
Member

I noticed that the path used is a bit backwards compared to the other URLs. Besides, it causes overlap in the way TeamCity CodeBetter badges were captured (the /teamcity/codebetter/….svg URL, which gives test passing states, can capture /teamcity/codebetter/…/coverage.svg URLs).

I chose to change it to something like this: /teamcity/coverage/bt1242.svg. Tell me if you disagree with this choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants