Log request data when Travis errors #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
|
Hi, there's an issue open for this #1611. I tend to think we should not bother to log these errors, as many of them will be spurious. For most services, we don't log the equivalent. Is there a reason to treat Travis differently? |
paulmelnikow
added
service-badge
|
It may be a transient error, or a real error. Either way, it was already logged, but it lacked information in the log for it to be useful: I can't tell what the problem actually was. In general, I feel logging the request data and the vendor response is useful to investigate errors. |
|
I don't feel strongly about this. |
# Conflicts: # server.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://sentry.io/shields/shields/issues/503517592/