[Vaadin Directory] Changed URI field star to stars
#1597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # lib/all-badge-examples.js
Generated by 🚫 dangerJS |
chris48s
requested changes
Mar 23, 2018
There was a problem hiding this comment.
Given this hasn't been deployed yet I think its reasonable to change the endpoint because every other service uses /stars as opposed to /star and there is no backwards-compatibility to break yet.
However, your pull request is difficult to review in its current form due to the unrelated commits and merge conflict. Could you fetch the latest upstream commits and rebase your changes onto master please?
|
Closing in favor of #1603. |
This was referenced Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.