Do not rate limit in dev

[paulmelnikow]

I ran into a rate limit while running the service tests, which seems not ideal!

I wonder if it would be better to set RATE_LIMIT=true on the server and default to false.

[shields-ci]

	Warnings
⚠️	This PR modified package.json, but not package-lock.json - Perhaps you need to run npm install?

	Messages
📖	✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS

[paulmelnikow]

@RedSparr0w Would you mind giving this a look?

[RedSparr0w]

Yeah this sounds good, doesn't make sense to rate limit ourselves,
Would whitelisting localhost/127.0.0.1 also work?

shields/lib/sys/monitor.js

Lines 21 to 28 in 09a2ca1

	const ipRateLimit = new RateLimit({
	whitelist: /^192\.30\.252\.\d+$/, // Whitelist GitHub IPs.
	});
	const badgeTypeRateLimit = new RateLimit({maxHitsPerPeriod: 3000});
	const refererRateLimit = new RateLimit({
	maxHitsPerPeriod: 300,
	whitelist: /^https?:\/\/shields\.io\/$/,
	});

[paulmelnikow]

Would whitelisting localhost/127.0.0.1 also work?

That is a great idea! Maybe that would be a simpler way to make this change.

[paulmelnikow]

Hmm, this code doesn't have any tests, though. Maybe it's better to merge the fix I'm confident in.

[RedSparr0w]

I can't seem to hit the rate limit, I've tried setting:

    this.period = 5000; 
    this.maxHitsPerPeriod = 10;

and also set RATE_LIMIT=true,
But still seems to pass the limit.

Even made 2 test using the static badge which ran 3500 times each and went through fine.
/badge/test-test-blue.json
/badge/test${i}-test${i}-blue.json

[paulmelnikow]

Hmm, did you run the service tests? The static badges aren't rate limited. Not sure whether cached badges would be, either.

[RedSparr0w]

That would probably be why then, just tried it on the static badge.
Will give it another go on new badge using a local JSON resource.

[paulmelnikow]

@RedSparr0w I've updated this. Would you mind taking it for another spin?

[RedSparr0w]

I still can't manage to get the server to rate limit no matter what i try, but i can't see this doing any harm.

[paulmelnikow]

Since you haven't been able to reproduce this, I think I'll close it until I run into the problem again.