Travis service tests from tutorial #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
chris48s
reviewed
Feb 27, 2018
service-tests/travis.js
Outdated
| t.create('connection error') | ||
| .get('/foo/bar.json') | ||
| .networkOff() | ||
| .expectJSON({ name: 'build', value: 'invalid' }); |
There was a problem hiding this comment.
usually we'd use 'inaccessible' for this case and 'invalid' when the response is malformed
There was a problem hiding this comment.
Looks good to merge when this is addressed!
There was a problem hiding this comment.
Thanks @chris48s, great idea. @paulmelnikow done
|
The first version of the tutorial was written before the service tests. I never noticed they included code for tests that weren't added to the code base! |
paulmelnikow
approved these changes
Mar 4, 2018
|
In the next PR I would like to use great |
chris48s
approved these changes
Mar 4, 2018
This was referenced Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service tests were introduced in #937 by @paulmelnikow. The tutorial is based on service tests of Travis CI, we do not have them in out codebase. Do you know why? I think it would be good idea to add them.