[chocolatey powershellgallery] add service tests for NuGet v2 services #1487
Conversation
| @@ -51,7 +51,7 @@ function mapNugetFeedv2({ camp, cache }, pattern, offset, getInfo) { | |||
| const badgeData = getBadgeData(site, data); | |||
| getNugetPackage(apiUrl, repo, null, request, function(err, data) { | |||
| if (err != null) { | |||
| badgeData.text[1] = 'inaccessible'; | |||
| badgeData.text[1] = err.message; | |||
There was a problem hiding this comment.
Few lines below there is a try-catch block. Catch block does not have tests. But in my opinion try-catch is unnecessary and can be removed. What do you think about it?
There was a problem hiding this comment.
yeah the JSON.parse() error is caught in getNugetPackage() so I've removed the others
service-tests/chocolatey.js
Outdated
| })); | ||
|
|
||
| t.create('version (pre) (not found)') | ||
| .get('/v/not-a-real-package.json') |
There was a problem hiding this comment.
Shouldn't we have /vpre/... here?
service-tests/powershellgallery.js
Outdated
| })); | ||
|
|
||
| t.create('version (pre) (not found)') | ||
| .get('/v/not-a-real-package.json') |
There was a problem hiding this comment.
Shouldn't we have /vpre/... here?
| .expectJSON({name: 'chocolatey', value: 'invalid'}); | ||
|
|
||
|
|
||
| // version |
There was a problem hiding this comment.
"version" and "pre version" badge can have different colors (yellow, orange or blue). Would you like to test these cases? Color value can be check using this approach
shields/service-tests/github.js
Lines 39 to 40 in 8ad176d
There was a problem hiding this comment.
I had not realised that it we had an endpoint to test the colours but I now see you added this in #1190 - this would probably be helpful in some other tests.
I think it would also be helpful to add an example to the testing docs to explain this feature for other contributors.
There was a problem hiding this comment.
I agree with you. I will try to add such example.
chris48s
force-pushed
the
test-nuget2
branch
from
8d992db to
0279848
Compare
|
Great. I've rebased and updated |
|
Thanks, Merged 🎉 |
If you merge #1471 ahead of this, I will rebase and refactor the 'unexpected' cases to use the abstraction @platan has added there.