Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows logo #1467

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Add Windows logo #1467

merged 1 commit into from
Jan 23, 2018

Conversation

george-hopkins
Copy link
Contributor

This patch adds the Windows logo. I think it would be nice if it would be included because many projects use multiple CI services to test or build artifacts on different platforms. With this icon, users can easily differentiate between.

Please feel free to close this PR (e.g. because there is no existing badge to add this logo to).

Examples

@shields-ci
Copy link

Messages
📖

✨ Thanks for your contribution to Shields, @george-hopkins!

Generated by 🚫 dangerJS

Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Looks good to me, the logo was optimised using SVGO (or similar tooling). I believe we have already quite a few logos not directly related to badges, so this should be fine. 👍

@RedSparr0w RedSparr0w merged commit 0fd6933 into badges:master Jan 23, 2018
@RedSparr0w
Copy link
Member

RedSparr0w commented Jan 23, 2018

Thanks for providing example badges with this PR!

Logo looks good to me.
Although this logo doesn't relate directly to any badges, There is already a few other popular services logos which do not relate to any badges directly, I could also see a few use cases for this logo.

Merged, Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants