Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpage: add missing titles + more badge previews #1305

Merged
merged 8 commits into from
Dec 5, 2017
Merged

webpage: add missing titles + more badge previews #1305

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ce14488
change to shorter example
tooomm Dec 1, 2017
03389f8
fix tests
tooomm Dec 1, 2017
d10597d
fix titles + revert to previewUri
tooomm Dec 1, 2017
0c3c24d
more title fixes
tooomm Dec 1, 2017
1c12e98
Merge branch 'master' into patch-2
tooomm Dec 1, 2017
3cb6270
example to preview
tooomm Dec 2, 2017
ff06f3a
Merge branch 'master' into patch-2
tooomm Dec 4, 2017
45a16c5
Revert "fix tests"
tooomm Dec 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions lib/all-badge-examples.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ const allBadgeExamples = [
previewUri: '/teamcity/http/teamcity.jetbrains.com/s/bt345.svg'
},
{
title: '(full build status)',
title: 'TeamCity (full build status)',
keywords: [
'teamcity'
],
Expand Down Expand Up @@ -1333,7 +1333,7 @@ const allBadgeExamples = [
documentation: githubDoc,
},
{
title: '',
title: 'GitHub issues',
previewUri: '/github/issues-raw/badges/shields.svg',
keywords: [
'GitHub',
Expand All @@ -1352,7 +1352,7 @@ const allBadgeExamples = [
documentation: githubDoc,
},
{
title: '',
title: 'GitHub pull requests',
previewUri: '/github/issues-pr-raw/cdnjs/cdnjs.svg',
keywords: [
'GitHub',
Expand All @@ -1371,7 +1371,7 @@ const allBadgeExamples = [
documentation: githubDoc,
},
{
title: '',
title: 'GitHub closed issues',
previewUri: '/github/issues-closed-raw/badges/shields.svg',
keywords: [
'GitHub',
Expand All @@ -1390,7 +1390,7 @@ const allBadgeExamples = [
documentation: githubDoc,
},
{
title: '',
title: 'GitHub closed pull requests',
previewUri: '/github/issues-pr-closed-raw/cdnjs/cdnjs.svg',
keywords: [
'GitHub',
Expand All @@ -1410,7 +1410,7 @@ const allBadgeExamples = [
documentation: githubDoc,
},
{
title: '',
title: 'GitHub issues by-label',
previewUri: '/github/issues-raw/badges/shields/service-badge.svg',
keywords: [
'GitHub',
Expand All @@ -1430,7 +1430,7 @@ const allBadgeExamples = [
documentation: githubDoc,
},
{
title: '',
title: 'GitHub pull requests by-label',
previewUri: '/github/issues-pr-raw/badges/shields/service-badge.svg',
keywords: [
'GitHub',
Expand All @@ -1452,7 +1452,7 @@ const allBadgeExamples = [
},
{
title: 'GitHub issue title',
exampleUri: '/github/issues/detail/title/badges/shields/979.svg',
previewUri: '/github/issues/detail/title/badges/shields/1290.svg',
keywords: [
'GitHub',
'issue',
Expand Down Expand Up @@ -1676,7 +1676,7 @@ const allBadgeExamples = [
previewUri: '/bitbucket/issues/atlassian/python-bitbucket.svg'
},
{
title: '',
title: 'Bitbucket issues',
previewUri: '/bitbucket/issues-raw/atlassian/python-bitbucket.svg',
keywords: [
'Bitbucket'
Expand All @@ -1687,7 +1687,7 @@ const allBadgeExamples = [
previewUri: '/bitbucket/pr/osrf/gazebo.svg'
},
{
title: '',
title: 'Bitbucket open pull requests',
previewUri: '/bitbucket/pr-raw/osrf/gazebo.svg',
keywords: [
'Bitbucket'
Expand Down Expand Up @@ -2046,15 +2046,15 @@ const allBadgeExamples = [
previewUri: '/issuestats/i/github/expressjs/express.svg'
},
{
title: '(long form)',
title: 'Issue Stats (long form)',
exampleUri: '/issuestats/i/long/github/expressjs/express.svg'
},
{
title: 'Issue Stats',
title: 'Pull Request Stats',
previewUri: '/issuestats/p/github/expressjs/express.svg'
},
{
title: '(long form)',
title: 'Pull Request Stats (long form)',
exampleUri: '/issuestats/p/long/github/expressjs/express.svg'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the title here to match what the badge is showing.

Example badge shows: pull closure | 16 hrs

},
{
Expand Down
6 changes: 3 additions & 3 deletions service-tests/github.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,10 +382,10 @@ t.create('github issue state')
}));

t.create('github issue title')
.get('/issues/detail/title/badges/shields/979.json')
.get('/issues/detail/title/badges/shields/1290.json')
.expectJSONTypes(Joi.object().keys({
name: 'issue 979',
value: 'Github rate limits cause transient service test failures in CI',
name: 'issue 1290',
value: 'Node 9 support',
}));

t.create('github issue author')
Expand Down