Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: global version category prefix query param [amo archlinux aur bower cdnjs chromewebstore cocoapods conan conda cookbook cpan cran crates ctan curseforge debian dockerVersion dub eclipsemarketplace elmpackage f-droid factorio fedora feedz flathub galaxytoolshed gem gitea] #10685

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

jNullj
Copy link
Contributor

@jNullj jNullj commented Nov 20, 2024

Altho i am aware of #6135 this is an attempt to make this manageable.
I dont mind if this ends up unused as i took this as an opportunity to play a bit with the codebase internals.

Let me know if you think this change is elegant and easy to maintain or more of an anchor might risks confusion in the codebase.

Introduce global category-specific query parameters and add versionPrefix support across version badges.

Copy link
Contributor

Warnings
⚠️ This PR modified service code for amo but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for archlinux but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for aur but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for bower but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for cdnjs but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for chrome-web-store but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for cocoapods but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for conan but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for conda but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for cookbook but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for cpan but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for cran but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for crates but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for ctan but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for curseforge but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for debian but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for docker but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for dub but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for eclipse-marketplace but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for elm-package but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for f-droid but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for factorio-mod-portal but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for fedora but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for feedz but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for flathub but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for galaxytoolshed but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for gem but not its test code.
That's okay so long as it's refactoring existing code.
⚠️ This PR modified service code for gitea but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @jNullj!

Generated by 🚫 dangerJS against 355586a

@jNullj jNullj changed the title feat: global version category prefix query param feat: global version category prefix query param [amo archlinux aur bower cdnjs chrome-web-store cocoapods conan conda cookbook cpan cran crates ctan curseforge debian docker dub eclipsemarketplace elmpackage fdroid factorio fedora feedz flathub galaxytoolshed gem gitea] Nov 20, 2024
@jNullj jNullj changed the title feat: global version category prefix query param [amo archlinux aur bower cdnjs chrome-web-store cocoapods conan conda cookbook cpan cran crates ctan curseforge debian docker dub eclipsemarketplace elmpackage fdroid factorio fedora feedz flathub galaxytoolshed gem gitea] feat: global version category prefix query param [amo archlinux aur bower cdnjs chromewebstore cocoapods conan conda cookbook cpan cran crates ctan curseforge debian docker dub eclipsemarketplace elmpackage f-droid factorio fedora feedz flathub galaxytoolshed gem gitea] Nov 20, 2024
@jNullj jNullj added service-badge New or updated service badge developer-experience Dev tooling, test framework, and CI core Server, BaseService, GitHub auth, Shared helpers labels Nov 21, 2024
@jNullj jNullj changed the title feat: global version category prefix query param [amo archlinux aur bower cdnjs chromewebstore cocoapods conan conda cookbook cpan cran crates ctan curseforge debian docker dub eclipsemarketplace elmpackage f-droid factorio fedora feedz flathub galaxytoolshed gem gitea] feat: global version category prefix query param [amo archlinux aur bower cdnjs chromewebstore cocoapods conan conda cookbook cpan cran crates ctan curseforge debian dockerVersion dub eclipsemarketplace elmpackage f-droid factorio fedora feedz flathub galaxytoolshed gem gitea] Nov 22, 2024
@chris48s
Copy link
Member

chris48s commented Nov 24, 2024

I think I am against adding this as a user configuration option but I won't block it if other maintainers agree with adding it.

@chris48s chris48s added the needs-discussion A consensus is needed to move forward label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Server, BaseService, GitHub auth, Shared helpers developer-experience Dev tooling, test framework, and CI needs-discussion A consensus is needed to move forward service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants