-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: global version category prefix query param [amo archlinux aur bower cdnjs chromewebstore cocoapods conan conda cookbook cpan cran crates ctan curseforge debian dockerVersion dub eclipsemarketplace elmpackage f-droid factorio fedora feedz flathub galaxytoolshed gem gitea] #10685
Open
jNullj
wants to merge
30
commits into
badges:master
Choose a base branch
from
jNullj:feat/version-prefix-query-param
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jNullj
changed the title
feat: global version category prefix query param
feat: global version category prefix query param [amo archlinux aur bower cdnjs chrome-web-store cocoapods conan conda cookbook cpan cran crates ctan curseforge debian docker dub eclipsemarketplace elmpackage fdroid factorio fedora feedz flathub galaxytoolshed gem gitea]
Nov 20, 2024
jNullj
changed the title
feat: global version category prefix query param [amo archlinux aur bower cdnjs chrome-web-store cocoapods conan conda cookbook cpan cran crates ctan curseforge debian docker dub eclipsemarketplace elmpackage fdroid factorio fedora feedz flathub galaxytoolshed gem gitea]
feat: global version category prefix query param [amo archlinux aur bower cdnjs chromewebstore cocoapods conan conda cookbook cpan cran crates ctan curseforge debian docker dub eclipsemarketplace elmpackage f-droid factorio fedora feedz flathub galaxytoolshed gem gitea]
Nov 20, 2024
jNullj
added
service-badge
New or updated service badge
developer-experience
Dev tooling, test framework, and CI
core
Server, BaseService, GitHub auth, Shared helpers
labels
Nov 21, 2024
jNullj
changed the title
feat: global version category prefix query param [amo archlinux aur bower cdnjs chromewebstore cocoapods conan conda cookbook cpan cran crates ctan curseforge debian docker dub eclipsemarketplace elmpackage f-droid factorio fedora feedz flathub galaxytoolshed gem gitea]
feat: global version category prefix query param [amo archlinux aur bower cdnjs chromewebstore cocoapods conan conda cookbook cpan cran crates ctan curseforge debian dockerVersion dub eclipsemarketplace elmpackage f-droid factorio fedora feedz flathub galaxytoolshed gem gitea]
Nov 22, 2024
I think I am against adding this as a user configuration option but I won't block it if other maintainers agree with adding it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
core
Server, BaseService, GitHub auth, Shared helpers
developer-experience
Dev tooling, test framework, and CI
needs-discussion
A consensus is needed to move forward
service-badge
New or updated service badge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altho i am aware of #6135 this is an attempt to make this manageable.
I dont mind if this ends up unused as i took this as an opportunity to play a bit with the codebase internals.
Let me know if you think this change is elegant and easy to maintain or more of an anchor might risks confusion in the codebase.
Introduce global category-specific query parameters and add versionPrefix support across version badges.