-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we limit badge width? #72
Comments
We could allow unlimited-width badges for now and revisit in the future if problems arise. As @daxter points out at #70 (comment), this is really only an issue for generic badges. Where we have a vendor, the width is constrained anyway. |
Yep, I remember thinking it's moot for vendors. Yeah, let's just try freedom. 😃 |
@whit537 Haha, GitHub's fastly cache is screwing with you. :-) |
Haha, yeah, I was about to say. 👍 to freedom. Besides, if/when this does become a problem, it's something we can control centrally so it won't require any change for users. (Sorry for falling off the earth, by the way! Still very busy.) |
@olivierlacan How about now? :-) |
@whit537 💥 |
Interesting discussion I think we should have based on #70 (comment).
Logically I would say no, but there might be reasons to regret that later on. @whit537, @ackerdev, can you see an issue?
Now that I give it a moment, we should probably not allow anything longer than the usual GitHub README page can display (722 pixels as of today). I know they prevent embedded images from overflowing by using
max-width: 100%
on any image within the container, but the scaling involved would render the badges illegible.The text was updated successfully, but these errors were encountered: