Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coveralls URLs don't work with underscores? #70

Closed
seanlinsley opened this issue Oct 16, 2013 · 8 comments
Closed

Coveralls URLs don't work with underscores? #70

seanlinsley opened this issue Oct 16, 2013 · 8 comments

Comments

@seanlinsley
Copy link
Contributor

guard/guard and resque/resque work, but collectiveidea/delayed_job and gregbell/active_admin don't.

@seanlinsley
Copy link
Contributor Author

Looks like hyphens break it as well: dimagi/commcare-hq

@chadwhitacre
Copy link
Contributor

The issue is that we're truncating names so the PNG isn't too big, but we're doing this before calling the backend service, so we end up with a 404 from there.

@seanlinsley
Copy link
Contributor Author

How would the name of the file markedly increase its size?

@chadwhitacre
Copy link
Contributor

@daxter The button itself would increase in width.

@seanlinsley
Copy link
Contributor Author

That would make sense for the custom badges, but badges for the current vendors already have a determinate width.
guard/guard
Gittip
Travis CI

@chadwhitacre
Copy link
Contributor

Should be fixed:


@olivierlacan
Copy link
Member

@whit537 Should we make a new issue for the cropping in your cheese example? Shouldn't it say collectiveidea/delayed_job ?

@chadwhitacre
Copy link
Contributor

Shouldn't it say collectiveidea/delayed_job?

@olivierlacan Depends. Do you want to place a limit on how wide badges can be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants